Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: Caleb Welton <cwelton@pivotal.io>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (1.0)
Subject: Re: Commit messages
Message-Id: <D1529115-C314-4AC1-AE70-4D14B1033411@pivotal.io>
Date: Wed, 30 Sep 2015 01:46:20 +0200
References: 
 <CADV3_P0e5U+BgS6EPvfGRze4dEbbC0vc_U2Stj+YD=BVNB7d8w@mail.gmail.com>
In-Reply-To: 
 <CADV3_P0e5U+BgS6EPvfGRze4dEbbC0vc_U2Stj+YD=BVNB7d8w@mail.gmail.com>
To: "dev@hawq.incubator.apache.org" <dev@hawq.incubator.apache.org>

+0.1 to Jimmy's suggestion.

> On Sep 30, 2015, at 12:31 AM, Jimmy Da <jd462@cornell.edu> wrote:
> 
> Not a big deal, just the OCD part of me want to bring this up.
> 
> According to
> https://cwiki.apache.org/confluence/display/HAWQ/Contributing+to+HAWQ, our
> commit message should look like
> 
> HAWQ-###*.* Commit message blah blah blah
> 
> We use period '.' to separate the JIRA number and the commit message.
> 
> I don't quite feel good about the '.', so I looked up a bunch of other
> Apache projects and found their separators:
> hbase uses just a space
> storm, hive, samza uses ":"
> 
> I really like the ":" separator as they convey the relationship between the
> JIRA number and the message explaining the JIRA number.
> 
> Can we change the commit messages to
> HAWQ-###: Commit message blah blah blah