hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhanwei Wang <zw...@pivotal.io>
Subject Re: Commit messages
Date Wed, 30 Sep 2015 01:32:18 GMT
Hi Caleb

The PR will automatically close if HAWQ-XXX is in the commit message.
"closes N" is not required.



On Wed, Sep 30, 2015 at 7:44 AM, Caleb Welton <cwelton@pivotal.io> wrote:

> Another related observation. The git commit hooks are setup to
> automatically close The github PRs if your commit message ends in (closes
> N) where N is your PR number - Roman please correct me if I have the syntax
> wrong.
>
> So when dealing with a commit from github you might use:
>
> HAWQ-1: remove .p4ignore files (closes 2)
>
> Then the PR will autoclose.
>
> > On Sep 30, 2015, at 12:31 AM, Jimmy Da <jd462@cornell.edu> wrote:
> >
> > Not a big deal, just the OCD part of me want to bring this up.
> >
> > According to
> > https://cwiki.apache.org/confluence/display/HAWQ/Contributing+to+HAWQ,
> our
> > commit message should look like
> >
> > HAWQ-###*.* Commit message blah blah blah
> >
> > We use period '.' to separate the JIRA number and the commit message.
> >
> > I don't quite feel good about the '.', so I looked up a bunch of other
> > Apache projects and found their separators:
> > hbase uses just a space
> > storm, hive, samza uses ":"
> >
> > I really like the ":" separator as they convey the relationship between
> the
> > JIRA number and the message explaining the JIRA number.
> >
> > Can we change the commit messages to
> > HAWQ-###: Commit message blah blah blah
>



-- 
Best Regards
----------

Zhanwei Wang

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message