hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jimmy Da <jd...@cornell.edu>
Subject Re: Commit messages
Date Wed, 30 Sep 2015 06:57:20 GMT
Good discussion. '.' will do :)

Jimmy Da
Electrical and Computer Engineering
Cornell University 2011

On Tue, Sep 29, 2015 at 11:19 PM, Caleb Welton <cwelton@pivotal.io> wrote:

> Makes sense.  I'm convinced.  Let's keep '.'
>
> > On Sep 30, 2015, at 8:05 AM, CHANG Lei <chang.lei.cn@gmail.com> wrote:
> >
> > Here is another background for the "." convention when I used that in the
> > proposal:
> >
> > It is the same to core components of hadoop (hdfs and yarn), and
> obviously
> > some more close collaboration between the teams are needed in future, for
> > example some yarn and hdfs related contribution might be from hawq, for
> > example libhdfs3 and libyarn et al
> >
> > Same convention is helpful.
> >
> > Cheers
> > Lei
> >
> >
> >
> >> On Wed, Sep 30, 2015 at 2:22 AM, Konstantin Boudnik <cos@apache.org>
> wrote:
> >>
> >> Very good point. Having a white-space isn't an option as you end up with
> >> more
> >> complex and potentially error-prone filtering if you need process logs
> >> automatically. And colon is aesthetically wrong in this context, IMO.
> '.'
> >> feels
> >> correct.
> >>
> >>> On Tue, Sep 29, 2015 at 03:31PM, Jimmy Da wrote:
> >>> Not a big deal, just the OCD part of me want to bring this up.
> >>>
> >>> According to
> >>> https://cwiki.apache.org/confluence/display/HAWQ/Contributing+to+HAWQ,
> >> our
> >>> commit message should look like
> >>>
> >>> HAWQ-###*.* Commit message blah blah blah
> >>>
> >>> We use period '.' to separate the JIRA number and the commit message.
> >>>
> >>> I don't quite feel good about the '.', so I looked up a bunch of other
> >>> Apache projects and found their separators:
> >>> hbase uses just a space
> >>> storm, hive, samza uses ":"
> >>>
> >>> I really like the ":" separator as they convey the relationship between
> >> the
> >>> JIRA number and the message explaining the JIRA number.
> >>>
> >>> Can we change the commit messages to
> >>> HAWQ-###: Commit message blah blah blah
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message