hawq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Boudnik <...@apache.org>
Subject Re: Commit messages
Date Wed, 30 Sep 2015 00:22:44 GMT
Very good point. Having a white-space isn't an option as you end up with more
complex and potentially error-prone filtering if you need process logs
automatically. And colon is aesthetically wrong in this context, IMO. '.' feels
correct.

On Tue, Sep 29, 2015 at 03:31PM, Jimmy Da wrote:
> Not a big deal, just the OCD part of me want to bring this up.
> 
> According to
> https://cwiki.apache.org/confluence/display/HAWQ/Contributing+to+HAWQ, our
> commit message should look like
> 
> HAWQ-###*.* Commit message blah blah blah
> 
> We use period '.' to separate the JIRA number and the commit message.
> 
> I don't quite feel good about the '.', so I looked up a bunch of other
> Apache projects and found their separators:
> hbase uses just a space
> storm, hive, samza uses ":"
> 
> I really like the ":" separator as they convey the relationship between the
> JIRA number and the message explaining the JIRA number.
> 
> Can we change the commit messages to
> HAWQ-###: Commit message blah blah blah

Mime
View raw message