Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B02CC200C29 for ; Tue, 28 Feb 2017 11:10:23 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AD1AB160B7C; Tue, 28 Feb 2017 10:10:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 038AC160B6A for ; Tue, 28 Feb 2017 11:10:22 +0100 (CET) Received: (qmail 98306 invoked by uid 500); 28 Feb 2017 10:10:22 -0000 Mailing-List: contact commits-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list commits@hawq.incubator.apache.org Received: (qmail 98297 invoked by uid 99); 28 Feb 2017 10:10:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2017 10:10:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BEACCC094B for ; Tue, 28 Feb 2017 10:10:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.567 X-Spam-Level: X-Spam-Status: No, score=-6.567 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id R_mnwAno6hmX for ; Tue, 28 Feb 2017 10:10:21 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 96AEC60DC0 for ; Tue, 28 Feb 2017 10:10:20 +0000 (UTC) Received: (qmail 94326 invoked by uid 99); 28 Feb 2017 10:09:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2017 10:09:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id AB4E0DFCA1; Tue, 28 Feb 2017 10:09:51 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: lilima@apache.org To: commits@hawq.incubator.apache.org Message-Id: <8b4b209446f6419faccd7335fa909619@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: incubator-hawq git commit: HAWQ-1366. Throw unsupported error out for dictionary page in Parquet storage Date: Tue, 28 Feb 2017 10:09:51 +0000 (UTC) archived-at: Tue, 28 Feb 2017 10:10:23 -0000 Repository: incubator-hawq Updated Branches: refs/heads/master 4820193c9 -> 6d5792c40 HAWQ-1366. Throw unsupported error out for dictionary page in Parquet storage Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/6d5792c4 Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/6d5792c4 Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/6d5792c4 Branch: refs/heads/master Commit: 6d5792c408461d7d58fa7633d939dd8900138681 Parents: 4820193 Author: Lili Ma Authored: Tue Feb 28 17:57:21 2017 +0800 Committer: Lili Ma Committed: Tue Feb 28 18:02:16 2017 +0800 ---------------------------------------------------------------------- src/backend/cdb/cdbparquetcolumn.c | 5 +++++ 1 file changed, 5 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/6d5792c4/src/backend/cdb/cdbparquetcolumn.c ---------------------------------------------------------------------- diff --git a/src/backend/cdb/cdbparquetcolumn.c b/src/backend/cdb/cdbparquetcolumn.c index 89ce684..083f669 100644 --- a/src/backend/cdb/cdbparquetcolumn.c +++ b/src/backend/cdb/cdbparquetcolumn.c @@ -146,6 +146,11 @@ ParquetExecutorReadColumn(ParquetColumnReader *columnReader, File file) /*just process data page now*/ if(pageHeader->page_type != DATA_PAGE){ + if(pageHeader->page_type == DICTIONARY_PAGE) { + ereport(ERROR, (errcode(ERRCODE_GP_INTERNAL_ERROR), + errmsg("HAWQ does not support dictionary page type resolver for Parquet format in column \'%s\' ", + columnChunkMetadata->colName))); + } buffer += pageHeader->compressed_page_size; continue; }