Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7370D200BA9 for ; Sun, 9 Oct 2016 05:35:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 69912160AEF; Sun, 9 Oct 2016 03:35:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AF184160ADF for ; Sun, 9 Oct 2016 05:35:53 +0200 (CEST) Received: (qmail 11722 invoked by uid 500); 9 Oct 2016 03:35:52 -0000 Mailing-List: contact commits-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list commits@hawq.incubator.apache.org Received: (qmail 11713 invoked by uid 99); 9 Oct 2016 03:35:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Oct 2016 03:35:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 54AE1C0A99 for ; Sun, 9 Oct 2016 03:35:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id afHGtweS96qx for ; Sun, 9 Oct 2016 03:35:50 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 5466C5F243 for ; Sun, 9 Oct 2016 03:35:49 +0000 (UTC) Received: (qmail 11683 invoked by uid 99); 9 Oct 2016 03:35:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Oct 2016 03:35:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2776BDFF55; Sun, 9 Oct 2016 03:35:48 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: huor@apache.org To: commits@hawq.incubator.apache.org Message-Id: <60c4a5d053b543d6b832545f368f83e2@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: incubator-hawq git commit: HAWQ-1051. Failing in reverse DNS lookup causes resource manager core dump Date: Sun, 9 Oct 2016 03:35:48 +0000 (UTC) archived-at: Sun, 09 Oct 2016 03:35:54 -0000 Repository: incubator-hawq Updated Branches: refs/heads/master 8928e88ea -> 4b3fdb262 HAWQ-1051. Failing in reverse DNS lookup causes resource manager core dump Signed-off-by: jiny2 Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/4b3fdb26 Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/4b3fdb26 Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/4b3fdb26 Branch: refs/heads/master Commit: 4b3fdb262832f056cb39e725331938721adb39d7 Parents: 8928e88 Author: stanlyxiang Authored: Wed Sep 21 23:57:27 2016 +0800 Committer: Ruilong Huo Committed: Sun Oct 9 11:35:45 2016 +0800 ---------------------------------------------------------------------- src/backend/resourcemanager/requesthandler.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/4b3fdb26/src/backend/resourcemanager/requesthandler.c ---------------------------------------------------------------------- diff --git a/src/backend/resourcemanager/requesthandler.c b/src/backend/resourcemanager/requesthandler.c index 9946322..976156b 100644 --- a/src/backend/resourcemanager/requesthandler.c +++ b/src/backend/resourcemanager/requesthandler.c @@ -627,7 +627,11 @@ bool handleRMSEGRequestIMAlive(void **arg) fts_client_ip_len = strlen(fts_client_ip); inet_aton(fts_client_ip, &fts_client_addr); fts_client_host = gethostbyaddr(&fts_client_addr, 4, AF_INET); - Assert(fts_client_host != NULL); + if (fts_client_host == NULL) + { + elog(WARNING, "Failed to reverse DNS lookup for ip %s.", fts_client_ip); + return true; + } /* Get the received machine id instance start address. */ SegInfo fts_client_seginfo = (SegInfo)(SMBUFF_CONTENT(&(conntrack->MessageBuff)) +