hawq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From h...@apache.org
Subject incubator-hawq git commit: HAWQ-1092. lc_collate and lc_ctype do not work after setting through hawq init
Date Tue, 11 Oct 2016 03:09:17 GMT
Repository: incubator-hawq
Updated Branches:
  refs/heads/master 5f3db03a7 -> 85192f8e4


HAWQ-1092. lc_collate and lc_ctype do not work after setting through hawq init


Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/85192f8e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/85192f8e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/85192f8e

Branch: refs/heads/master
Commit: 85192f8e4742fe206b1c5f9f86b0c85d5e086cf6
Parents: 5f3db03
Author: Paul Guo <paulguo@gmail.com>
Authored: Sun Oct 9 17:47:32 2016 +0800
Committer: Ruilong Huo <rhuo@pivotal.io>
Committed: Tue Oct 11 11:09:30 2016 +0800

----------------------------------------------------------------------
 src/backend/access/transam/xlog.c    |  2 ++
 src/test/feature/README.md           |  2 +-
 src/test/feature/catalog/ans/guc.ans | 12 ++++++++++++
 src/test/feature/catalog/sql/guc.sql |  2 ++
 4 files changed, 17 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/85192f8e/src/backend/access/transam/xlog.c
----------------------------------------------------------------------
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index a0b3c82..eeef04e 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -5299,6 +5299,8 @@ XLOGShmemInit(void)
 void
 XLogStartupInit(void)
 {
+	if (!IsBootstrapProcessingMode())
+		ReadControlFile();
 }
 
 /*

http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/85192f8e/src/test/feature/README.md
----------------------------------------------------------------------
diff --git a/src/test/feature/README.md b/src/test/feature/README.md
index 229c7c4..2e27f97 100644
--- a/src/test/feature/README.md
+++ b/src/test/feature/README.md
@@ -12,7 +12,7 @@ Also, you could enter the `$HAWQ_HOME/src/test/feature` folder to `make`
and `ma
 Before building the code of feature tests part, just make sure your compiler supports C++11
and you have apache HAWQ successfully compiled.
 
 # Run
-1. Make sure HAWQ is running correctly. If not, `init` or `start` HAWQ at first.
+1. Make sure HAWQ is running correctly. If not, `init` or `start` HAWQ at first. Note please
don't set locale related arguments for hawq init.
 2. Load environment configuration by running `source $INSTALL_PREFIX/greenplum_path.sh`.
 3. Load hdfs configuration. For example, `export HADOOP_HOME=/Users/wuhong/hadoop-2.7.2 &&
export PATH=${PATH}:${HADOOP_HOME}/bin`. Since some test cases need `hdfs` and `hadoop` command,
just ensure these commands work before running. Otherwise you will get failure.
 4. Run `./feature-test`, you could use `--gtest_filter` option to filter test cases(both
positive and negative patterns are supported). Please see more options by running `./feature-test
--help`.

http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/85192f8e/src/test/feature/catalog/ans/guc.ans
----------------------------------------------------------------------
diff --git a/src/test/feature/catalog/ans/guc.ans b/src/test/feature/catalog/ans/guc.ans
index 7c4595c..117d365 100644
--- a/src/test/feature/catalog/ans/guc.ans
+++ b/src/test/feature/catalog/ans/guc.ans
@@ -24,3 +24,15 @@ SELECT f1 FROM DATE_TBL;
  09-04-1957
 (1 row)
 
+--- Partially test JIRA HAWQ-1092 lc_collate and lc_ctype do not work after setting through
hawq init
+SELECT name, setting from pg_settings where name like 'lc%'
+    name     |  setting   
+-------------+------------
+ lc_collate  | en_US.utf8
+ lc_ctype    | en_US.utf8
+ lc_messages | en_US.utf8
+ lc_monetary | en_US.utf8
+ lc_numeric  | en_US.utf8
+ lc_time     | en_US.utf8
+(6 rows)
+

http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/85192f8e/src/test/feature/catalog/sql/guc.sql
----------------------------------------------------------------------
diff --git a/src/test/feature/catalog/sql/guc.sql b/src/test/feature/catalog/sql/guc.sql
index cf16538..f22fb8c 100644
--- a/src/test/feature/catalog/sql/guc.sql
+++ b/src/test/feature/catalog/sql/guc.sql
@@ -9,3 +9,5 @@ SELECT f1 FROM DATE_TBL;
 SET DATESTYLE TO 'POSTGRES, DMY';
 SELECT f1 FROM DATE_TBL;
 
+--- Partially test JIRA HAWQ-1092 lc_collate and lc_ctype do not work after setting through
hawq init
+SELECT name, setting from pg_settings where name like 'lc%'


Mime
View raw message