Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2ACE3200B96 for ; Thu, 22 Sep 2016 03:19:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 29532160AE3; Thu, 22 Sep 2016 01:19:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 67D06160ADB for ; Thu, 22 Sep 2016 03:19:44 +0200 (CEST) Received: (qmail 52529 invoked by uid 500); 22 Sep 2016 01:19:43 -0000 Mailing-List: contact commits-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list commits@hawq.incubator.apache.org Received: (qmail 52520 invoked by uid 99); 22 Sep 2016 01:19:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2016 01:19:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3A390180286 for ; Thu, 22 Sep 2016 01:19:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id tIcabGdFGKOv for ; Thu, 22 Sep 2016 01:19:41 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 76E4260D08 for ; Thu, 22 Sep 2016 01:19:40 +0000 (UTC) Received: (qmail 52471 invoked by uid 99); 22 Sep 2016 01:19:39 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2016 01:19:39 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7E4F3E1772; Thu, 22 Sep 2016 01:19:39 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: odiachenko@apache.org To: commits@hawq.incubator.apache.org Date: Thu, 22 Sep 2016 01:19:42 -0000 Message-Id: In-Reply-To: <9d7f891ef3784635803322d2a7b66c36@git.apache.org> References: <9d7f891ef3784635803322d2a7b66c36@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [4/4] incubator-hawq git commit: HAWQ-1048. Return NULL instead of empty string. archived-at: Thu, 22 Sep 2016 01:19:45 -0000 HAWQ-1048. Return NULL instead of empty string. Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/0ff70373 Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/0ff70373 Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/0ff70373 Branch: refs/heads/HAWQ-1048 Commit: 0ff70373b3b700028892c72fd9e1fb516bbcaa25 Parents: 7a9cc88 Author: Oleksandr Diachenko Authored: Wed Sep 21 18:19:18 2016 -0700 Committer: Oleksandr Diachenko Committed: Wed Sep 21 18:19:18 2016 -0700 ---------------------------------------------------------------------- src/backend/access/external/pxffilters.c | 6 ++++++ 1 file changed, 6 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/0ff70373/src/backend/access/external/pxffilters.c ---------------------------------------------------------------------- diff --git a/src/backend/access/external/pxffilters.c b/src/backend/access/external/pxffilters.c index 0d1e1fa..8c3864d 100644 --- a/src/backend/access/external/pxffilters.c +++ b/src/backend/access/external/pxffilters.c @@ -317,6 +317,12 @@ pxf_serialize_filter_list(List *expressionItems) } } + if (resbuf->len == 0) + { + pfree(resbuf->data); + return NULL; + } + return resbuf->data; }