hawq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From odiache...@apache.org
Subject incubator-hawq git commit: HAWQ-1053. Added more comments.
Date Fri, 16 Sep 2016 00:26:29 GMT
Repository: incubator-hawq
Updated Branches:
  refs/heads/HAWQ-1053 f847f2617 -> 54e818a09


HAWQ-1053. Added more comments.


Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/54e818a0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/54e818a0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/54e818a0

Branch: refs/heads/HAWQ-1053
Commit: 54e818a0995e33c5597a16fe6558448605e53a12
Parents: f847f26
Author: Oleksandr Diachenko <odiachenko@pivotal.io>
Authored: Thu Sep 15 17:26:18 2016 -0700
Committer: Oleksandr Diachenko <odiachenko@pivotal.io>
Committed: Thu Sep 15 17:26:18 2016 -0700

----------------------------------------------------------------------
 src/backend/access/external/pxffilters.c | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/54e818a0/src/backend/access/external/pxffilters.c
----------------------------------------------------------------------
diff --git a/src/backend/access/external/pxffilters.c b/src/backend/access/external/pxffilters.c
index adfa782..6767735 100644
--- a/src/backend/access/external/pxffilters.c
+++ b/src/backend/access/external/pxffilters.c
@@ -495,20 +495,24 @@ get_attrs_from_expr(Expr *expr)
 	}
 
 	//Process left operand
+	//For most of datatypes column is represented by Var node
 	if (IsA(leftop, Var))
 	{
 		attrs = append_attr_from_var((Var *) leftop, attrs);
 	}
+	//For varchar column is represented by RelabelType node
 	if (IsA(leftop, RelabelType))
 	{
 		attrs = append_attr_from_var((Var *) ((RelabelType *) leftop)->arg, attrs);
 	}
 
 	//Process right operand
+	//For most of datatypes column is represented by Var node
 	if (IsA(rightop, Var))
 	{
 		attrs = append_attr_from_var((Var *) rightop, attrs);
 	}
+	//For varchar column is represented by RelabelType node
 	if (IsA(rightop, RelabelType))
 	{
 		attrs = append_attr_from_var((Var *) ((RelabelType *) rightop)->arg, attrs);


Mime
View raw message