Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 184532009C6 for ; Tue, 17 May 2016 05:01:36 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 16A67160A19; Tue, 17 May 2016 03:01:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5F221160A16 for ; Tue, 17 May 2016 05:01:35 +0200 (CEST) Received: (qmail 36835 invoked by uid 500); 17 May 2016 03:01:34 -0000 Mailing-List: contact commits-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list commits@hawq.incubator.apache.org Received: (qmail 36826 invoked by uid 99); 17 May 2016 03:01:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 May 2016 03:01:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1B0E61A4EEF for ; Tue, 17 May 2016 03:01:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.221 X-Spam-Level: X-Spam-Status: No, score=-3.221 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id G49WlAGtMtek for ; Tue, 17 May 2016 03:01:32 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id E0C765FB08 for ; Tue, 17 May 2016 03:01:31 +0000 (UTC) Received: (qmail 36816 invoked by uid 99); 17 May 2016 03:01:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 May 2016 03:01:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id F044BDFC77; Tue, 17 May 2016 03:01:30 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: yjin@apache.org To: commits@hawq.incubator.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: incubator-hawq git commit: HAWQ-737. Last action time should be initialized as created time instead of 0 Date: Tue, 17 May 2016 03:01:30 +0000 (UTC) archived-at: Tue, 17 May 2016 03:01:36 -0000 Repository: incubator-hawq Updated Branches: refs/heads/master 101adfab1 -> cec472dca HAWQ-737. Last action time should be initialized as created time instead of 0 Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/cec472dc Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/cec472dc Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/cec472dc Branch: refs/heads/master Commit: cec472dcab39a03ca31103c30b6fe32f0abfaa19 Parents: 101adfa Author: YI JIN Authored: Tue May 17 13:01:23 2016 +1000 Committer: YI JIN Committed: Tue May 17 13:01:23 2016 +1000 ---------------------------------------------------------------------- src/backend/resourcemanager/conntrack.c | 2 +- src/backend/resourcemanager/resqueuemanager.c | 21 ++++++++++++++------- 2 files changed, 15 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/cec472dc/src/backend/resourcemanager/conntrack.c ---------------------------------------------------------------------- diff --git a/src/backend/resourcemanager/conntrack.c b/src/backend/resourcemanager/conntrack.c index c5b0fbf..5811c08 100644 --- a/src/backend/resourcemanager/conntrack.c +++ b/src/backend/resourcemanager/conntrack.c @@ -103,7 +103,7 @@ void createEmptyConnectionTrack(ConnectionTrack *track) (*track)->RegisterTime = 0; (*track)->ResRequestTime = 0; (*track)->ResAllocTime = 0; - (*track)->LastActTime = 0; + (*track)->LastActTime = gettime_microsec(); (*track)->HeadQueueTime = 0; (*track)->MessageSize = 0; http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/cec472dc/src/backend/resourcemanager/resqueuemanager.c ---------------------------------------------------------------------- diff --git a/src/backend/resourcemanager/resqueuemanager.c b/src/backend/resourcemanager/resqueuemanager.c index cf4dc1f..2916df9 100644 --- a/src/backend/resourcemanager/resqueuemanager.c +++ b/src/backend/resourcemanager/resqueuemanager.c @@ -4509,8 +4509,11 @@ void timeoutDeadResourceAllocation(void) if ( curmsec - curcon->LastActTime > 1000000L * rm_session_lease_timeout ) { - elog(LOG, "ConnID %d. The allocated resource timeout is detected.", - curcon->ConnID); + elog(WARNING, "ConnID %d. The allocated resource timeout is " + "detected. Last action time is "UINT64_FORMAT + "msec ago.", + curcon->ConnID, + curmsec - curcon->LastActTime); returnResourceToResQueMgr(curcon); returnConnectionToQueue(curcon, true); if ( curcon->CommBuffer != NULL ) @@ -4530,9 +4533,11 @@ void timeoutDeadResourceAllocation(void) if ( curmsec - curcon->LastActTime > 1000000L * rm_session_lease_timeout ) { - elog(LOG, "ConnID %d. The queued resource request timeout is " - "detected.", - curcon->ConnID); + elog(WARNING, "ConnID %d. The queued resource request timeout is " + "detected. Last action time is "UINT64_FORMAT + "msec ago", + curcon->ConnID, + curmsec - curcon->LastActTime); snprintf(errorbuf, sizeof(errorbuf), "queued resource request is timed out due to no session " @@ -4558,8 +4563,10 @@ void timeoutDeadResourceAllocation(void) 1000000L * rm_session_lease_timeout ) { elog(WARNING, "The registered connection timeout is detected. " - "ConnID %d", - curcon->ConnID); + "ConnID %d. Last action time is "UINT64_FORMAT + "msec ago", + curcon->ConnID, + curmsec - curcon->LastActTime); returnConnectionToQueue(curcon, true); if ( curcon->CommBuffer != NULL ) {