hawq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shiv...@apache.org
Subject incubator-hawq git commit: HAWQ-459. Updates to comments
Date Wed, 16 Mar 2016 18:11:44 GMT
Repository: incubator-hawq
Updated Branches:
  refs/heads/HAWQ-459 854f1aa43 -> c20a81d4f


HAWQ-459. Updates to comments


Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/c20a81d4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/c20a81d4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/c20a81d4

Branch: refs/heads/HAWQ-459
Commit: c20a81d4f0c7443535407bd90f253a167be1b57f
Parents: 854f1aa
Author: Shivram Mani <shivram.mani@gmail.com>
Authored: Wed Mar 16 11:11:38 2016 -0700
Committer: Shivram Mani <shivram.mani@gmail.com>
Committed: Wed Mar 16 11:11:38 2016 -0700

----------------------------------------------------------------------
 pxf/README.md                                                  | 2 +-
 .../src/main/java/org/apache/hawq/pxf/api/Metadata.java        | 6 +++---
 .../org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java   | 4 ++--
 .../org/apache/hawq/pxf/plugins/hive/HiveMetadataFetcher.java  | 6 +++---
 pxf/src/scripts/pxf_manual_failover.py                         | 2 +-
 5 files changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/c20a81d4/pxf/README.md
----------------------------------------------------------------------
diff --git a/pxf/README.md b/pxf/README.md
index c8e7a3f..b7cd7f0 100644
--- a/pxf/README.md
+++ b/pxf/README.md
@@ -12,7 +12,7 @@ Introduction
 ============
 
 PXF is an extensible framework that allows HAWQ to query external system data.
-PXF includes built-in connectors for accessing data that exists inside HDFS files, Hive items,
HBase items and more.
+PXF includes built-in connectors for accessing data that exists inside HDFS files, Hive tables,
HBase tables and more.
 Users can also create their own connectors to other parallel data stores or processing engines.
 To create these connectors using JAVA plugins, see the Pivotal Extension Framework API and
Reference Guide .
 

http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/c20a81d4/pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/Metadata.java
----------------------------------------------------------------------
diff --git a/pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/Metadata.java b/pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/Metadata.java
index 7a044d6..26ad182 100644
--- a/pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/Metadata.java
+++ b/pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/Metadata.java
@@ -26,13 +26,13 @@ import java.util.List;
 import org.apache.commons.lang.StringUtils;
 
 /**
- * Metadata holds a item's metadata information.
+ * Metadata holds an item's metadata information.
  * {@link MetadataFetcher#getMetadata} returns the item's metadata.
  */
 public class Metadata {
 
     /**
-     * Class representing item name - db (schema) name and item name.
+     * Class representing item name - db/schema/path name and table/file name.
      */
     public static class Item {
         private String path;
@@ -113,7 +113,7 @@ public class Metadata {
     private List<Metadata.Field> fields;
 
     /**
-     * Constructs a item's Metadata.
+     * Constructs an item's Metadata.
      *
      * @param itemName the item name
      * @param fields the item's fields

http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/c20a81d4/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java
----------------------------------------------------------------------
diff --git a/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java
b/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java
index f8e4e08..e4e34b0 100644
--- a/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java
+++ b/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java
@@ -217,7 +217,7 @@ public class HiveDataFragmenter extends Fragmenter {
             if (partitions == null || partitions.isEmpty()) {
 
                 if (LOG.isDebugEnabled()) {
-                    LOG.debug("Item -  " + tblDesc.getPath() + "."
+                    LOG.debug("Table -  " + tblDesc.getPath() + "."
                             + tblDesc.getName()
                             + " Has no matched partitions for the filter : "
                             + filterStringForHive);
@@ -226,7 +226,7 @@ public class HiveDataFragmenter extends Fragmenter {
             }
 
             if (LOG.isDebugEnabled()) {
-                LOG.debug("Item -  " + tblDesc.getPath() + "."
+                LOG.debug("Table -  " + tblDesc.getPath() + "."
                         + tblDesc.getName()
                         + " Matched partitions list size: " + partitions.size());
             }

http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/c20a81d4/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveMetadataFetcher.java
----------------------------------------------------------------------
diff --git a/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveMetadataFetcher.java
b/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveMetadataFetcher.java
index 20014c2..e41d537 100644
--- a/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveMetadataFetcher.java
+++ b/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveMetadataFetcher.java
@@ -50,9 +50,9 @@ public class HiveMetadataFetcher extends MetadataFetcher {
     }
 
     @Override
-    public List<Metadata> getMetadata(String itemName) throws Exception {
+    public List<Metadata> getMetadata(String tableName) throws Exception {
 
-        List<Metadata.Item> tblsDesc = HiveUtilities.extractTablesFromPattern(client,
itemName);
+        List<Metadata.Item> tblsDesc = HiveUtilities.extractTablesFromPattern(client,
tableName);
         List<Metadata> metadataList = new ArrayList<Metadata>();
 
         for(Metadata.Item tblDesc: tblsDesc) {
@@ -67,7 +67,7 @@ public class HiveMetadataFetcher extends MetadataFetcher {
 
 
     /**
-     * Populates the given metadata item with the given table's fields and partitions,
+     * Populates the given metadata object with the given table's fields and partitions,
      * The partition fields are added at the end of the table schema.
      * Throws an exception if the table contains unsupported field types.
      * Supported HCatalog types: TINYINT,

http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/c20a81d4/pxf/src/scripts/pxf_manual_failover.py
----------------------------------------------------------------------
diff --git a/pxf/src/scripts/pxf_manual_failover.py b/pxf/src/scripts/pxf_manual_failover.py
index 4668ac2..a9f51e5 100755
--- a/pxf/src/scripts/pxf_manual_failover.py
+++ b/pxf/src/scripts/pxf_manual_failover.py
@@ -17,7 +17,7 @@
 # under the License.
 
 # pxf_manual_failover.py
-# This python script will adapt the PXF external items to the new NameNode in case
+# This python script will adapt the PXF external tables to the new NameNode in case
 # of High Availability manual failover. 
 # The script receives as input the new namenode host and then goes over each external
 # table entry in the catalog table pg_exttable and updates the LOCATION field - 


Mime
View raw message