Return-Path: X-Original-To: apmail-hawq-commits-archive@minotaur.apache.org Delivered-To: apmail-hawq-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 22F3C18E93 for ; Thu, 14 Jan 2016 07:47:53 +0000 (UTC) Received: (qmail 15798 invoked by uid 500); 14 Jan 2016 07:47:53 -0000 Delivered-To: apmail-hawq-commits-archive@hawq.apache.org Received: (qmail 15761 invoked by uid 500); 14 Jan 2016 07:47:53 -0000 Mailing-List: contact commits-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list commits@hawq.incubator.apache.org Received: (qmail 15752 invoked by uid 99); 14 Jan 2016 07:47:53 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jan 2016 07:47:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7E27AC2174 for ; Thu, 14 Jan 2016 07:47:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.78 X-Spam-Level: * X-Spam-Status: No, score=1.78 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id LNcS3Y043478 for ; Thu, 14 Jan 2016 07:47:51 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 7A190428ED for ; Thu, 14 Jan 2016 07:47:51 +0000 (UTC) Received: (qmail 15721 invoked by uid 99); 14 Jan 2016 07:47:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jan 2016 07:47:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0011EE0A96; Thu, 14 Jan 2016 07:47:50 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: mli@apache.org To: commits@hawq.incubator.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: incubator-hawq git commit: Revert "HAWQ-169. remove useless variable found by coverity" for installcheck-good find a new bug after it fixed. Date: Thu, 14 Jan 2016 07:47:50 +0000 (UTC) Repository: incubator-hawq Updated Branches: refs/heads/master 2984ec6f9 -> 7459a3b9c Revert "HAWQ-169. remove useless variable found by coverity" for installcheck-good find a new bug after it fixed. This reverts commit 2984ec6f947d25230e28b4c763d9bbe534751b3a. Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/7459a3b9 Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/7459a3b9 Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/7459a3b9 Branch: refs/heads/master Commit: 7459a3b9c922b76b5e590fab5c61e755800b0f05 Parents: 2984ec6 Author: Ming LI Authored: Thu Jan 14 15:44:54 2016 +0800 Committer: Ming LI Committed: Thu Jan 14 15:44:54 2016 +0800 ---------------------------------------------------------------------- src/bin/pg_dump/pg_dumpall.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/7459a3b9/src/bin/pg_dump/pg_dumpall.c ---------------------------------------------------------------------- diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c index 5c3c6f7..7538ff2 100644 --- a/src/bin/pg_dump/pg_dumpall.c +++ b/src/bin/pg_dump/pg_dumpall.c @@ -990,7 +990,7 @@ dumpRoleMembership(PGconn *conn) } /* - * Dump role time constraints. + * Dump role time constraints. * * Note: we expect dumpRoles already created all the roles, but there are * no time constraints yet. @@ -1017,7 +1017,7 @@ dumpRoleConstraints(PGconn *conn) char *end_day = PQgetvalue(res, i, 3); char *end_time = PQgetvalue(res, i, 4); - fprintf(OPF, "ALTER ROLE %s DENY BETWEEN DAY %s TIME '%s' AND DAY %s TIME '%s';\n", + fprintf(OPF, "ALTER ROLE %s DENY BETWEEN DAY %s TIME '%s' AND DAY %s TIME '%s';\n", fmtId(rolname), start_day, start_time, end_day, end_time); } @@ -1238,6 +1238,7 @@ dumpFilespaces(PGconn *conn) /* append the filespace location information to output */ for (j = 0; j < PQntuples(entries); j++) { + char *dbid = PQgetvalue(entries, j, 0); char *location = PQgetvalue(entries, j, 1); if (j > 0) @@ -1299,7 +1300,7 @@ dumpTablespaces(PGconn *conn) * --gp-syntax or --no-gp-syntax. */ if (server_version < 80214) - { + { /* Filespaces were introduced in GP 4.0 (server_version 8.2.14) */ return; }