Return-Path: X-Original-To: apmail-hawq-commits-archive@minotaur.apache.org Delivered-To: apmail-hawq-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C874F18CF4 for ; Thu, 14 Jan 2016 07:03:03 +0000 (UTC) Received: (qmail 96771 invoked by uid 500); 14 Jan 2016 07:03:03 -0000 Delivered-To: apmail-hawq-commits-archive@hawq.apache.org Received: (qmail 96731 invoked by uid 500); 14 Jan 2016 07:03:03 -0000 Mailing-List: contact commits-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list commits@hawq.incubator.apache.org Received: (qmail 96722 invoked by uid 99); 14 Jan 2016 07:03:03 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jan 2016 07:03:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 210FB1804CD for ; Thu, 14 Jan 2016 07:03:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.247 X-Spam-Level: * X-Spam-Status: No, score=1.247 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.554, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id fJqhrmhvHhWx for ; Thu, 14 Jan 2016 07:02:55 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 6934720506 for ; Thu, 14 Jan 2016 07:02:55 +0000 (UTC) Received: (qmail 96615 invoked by uid 99); 14 Jan 2016 07:02:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jan 2016 07:02:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1A2B6E0A96; Thu, 14 Jan 2016 07:02:55 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: mli@apache.org To: commits@hawq.incubator.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: incubator-hawq git commit: HAWQ-169. remove useless variable found by coverity Date: Thu, 14 Jan 2016 07:02:55 +0000 (UTC) Repository: incubator-hawq Updated Branches: refs/heads/master ba500a5c0 -> 2984ec6f9 HAWQ-169. remove useless variable found by coverity Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/2984ec6f Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/2984ec6f Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/2984ec6f Branch: refs/heads/master Commit: 2984ec6f947d25230e28b4c763d9bbe534751b3a Parents: ba500a5 Author: Ming LI Authored: Thu Jan 14 15:02:00 2016 +0800 Committer: Ming LI Committed: Thu Jan 14 15:02:00 2016 +0800 ---------------------------------------------------------------------- src/bin/pg_dump/pg_dumpall.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/2984ec6f/src/bin/pg_dump/pg_dumpall.c ---------------------------------------------------------------------- diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c index 7538ff2..5c3c6f7 100644 --- a/src/bin/pg_dump/pg_dumpall.c +++ b/src/bin/pg_dump/pg_dumpall.c @@ -990,7 +990,7 @@ dumpRoleMembership(PGconn *conn) } /* - * Dump role time constraints. + * Dump role time constraints. * * Note: we expect dumpRoles already created all the roles, but there are * no time constraints yet. @@ -1017,7 +1017,7 @@ dumpRoleConstraints(PGconn *conn) char *end_day = PQgetvalue(res, i, 3); char *end_time = PQgetvalue(res, i, 4); - fprintf(OPF, "ALTER ROLE %s DENY BETWEEN DAY %s TIME '%s' AND DAY %s TIME '%s';\n", + fprintf(OPF, "ALTER ROLE %s DENY BETWEEN DAY %s TIME '%s' AND DAY %s TIME '%s';\n", fmtId(rolname), start_day, start_time, end_day, end_time); } @@ -1238,7 +1238,6 @@ dumpFilespaces(PGconn *conn) /* append the filespace location information to output */ for (j = 0; j < PQntuples(entries); j++) { - char *dbid = PQgetvalue(entries, j, 0); char *location = PQgetvalue(entries, j, 1); if (j > 0) @@ -1300,7 +1299,7 @@ dumpTablespaces(PGconn *conn) * --gp-syntax or --no-gp-syntax. */ if (server_version < 80214) - { + { /* Filespaces were introduced in GP 4.0 (server_version 8.2.14) */ return; }