hawq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m..@apache.org
Subject incubator-hawq git commit: Revert "HAWQ-169. remove useless variable found by coverity" for installcheck-good find a new bug after it fixed.
Date Thu, 14 Jan 2016 07:47:50 GMT
Repository: incubator-hawq
Updated Branches:
  refs/heads/master 2984ec6f9 -> 7459a3b9c


Revert "HAWQ-169. remove useless variable found by coverity" for installcheck-good find a
new bug after it fixed.

This reverts commit 2984ec6f947d25230e28b4c763d9bbe534751b3a.


Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/7459a3b9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/7459a3b9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/7459a3b9

Branch: refs/heads/master
Commit: 7459a3b9c922b76b5e590fab5c61e755800b0f05
Parents: 2984ec6
Author: Ming LI <mli@pivotal.io>
Authored: Thu Jan 14 15:44:54 2016 +0800
Committer: Ming LI <mli@pivotal.io>
Committed: Thu Jan 14 15:44:54 2016 +0800

----------------------------------------------------------------------
 src/bin/pg_dump/pg_dumpall.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/7459a3b9/src/bin/pg_dump/pg_dumpall.c
----------------------------------------------------------------------
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
index 5c3c6f7..7538ff2 100644
--- a/src/bin/pg_dump/pg_dumpall.c
+++ b/src/bin/pg_dump/pg_dumpall.c
@@ -990,7 +990,7 @@ dumpRoleMembership(PGconn *conn)
 }
 
 /*
- * Dump role time constraints.
+ * Dump role time constraints. 
  *
  * Note: we expect dumpRoles already created all the roles, but there are
  * no time constraints yet.
@@ -1017,7 +1017,7 @@ dumpRoleConstraints(PGconn *conn)
 		char		*end_day 	= PQgetvalue(res, i, 3);
 		char 		*end_time 	= PQgetvalue(res, i, 4);
 
-		fprintf(OPF, "ALTER ROLE %s DENY BETWEEN DAY %s TIME '%s' AND DAY %s TIME '%s';\n",
+		fprintf(OPF, "ALTER ROLE %s DENY BETWEEN DAY %s TIME '%s' AND DAY %s TIME '%s';\n", 
 				fmtId(rolname), start_day, start_time, end_day, end_time);
 	}
 
@@ -1238,6 +1238,7 @@ dumpFilespaces(PGconn *conn)
 		/* append the filespace location information to output */
 		for (j = 0; j < PQntuples(entries); j++)
 		{
+			char	   *dbid = PQgetvalue(entries, j, 0);
 			char	   *location = PQgetvalue(entries, j, 1);
 
 			if (j > 0)
@@ -1299,7 +1300,7 @@ dumpTablespaces(PGconn *conn)
 	 * --gp-syntax or --no-gp-syntax.
 	 */
 	if (server_version < 80214)
-	{
+	{							
 		/* Filespaces were introduced in GP 4.0 (server_version 8.2.14) */
 		return;
 	}


Mime
View raw message