hawq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m..@apache.org
Subject incubator-hawq git commit: HAWQ-347. Fixed dead lock between pg_filespace lock and PersistentObjLock
Date Tue, 19 Jan 2016 02:23:35 GMT
Repository: incubator-hawq
Updated Branches:
  refs/heads/master 3554bfd43 -> 0019b5270


HAWQ-347. Fixed dead lock between pg_filespace lock and PersistentObjLock


Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/0019b527
Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/0019b527
Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/0019b527

Branch: refs/heads/master
Commit: 0019b52705d1abcb608d48fc999dbd029fa8ff8b
Parents: 3554bfd
Author: Ming LI <mli@pivotal.io>
Authored: Mon Jan 18 15:59:51 2016 +0800
Committer: Ming LI <mli@pivotal.io>
Committed: Tue Jan 19 10:22:47 2016 +0800

----------------------------------------------------------------------
 src/backend/access/transam/xlog_mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/0019b527/src/backend/access/transam/xlog_mm.c
----------------------------------------------------------------------
diff --git a/src/backend/access/transam/xlog_mm.c b/src/backend/access/transam/xlog_mm.c
index 20a6eb7..9f43341 100644
--- a/src/backend/access/transam/xlog_mm.c
+++ b/src/backend/access/transam/xlog_mm.c
@@ -495,7 +495,7 @@ emit_mmxlog_fs_record(mm_fs_obj_type type, Oid filespace,
 	xlrec.database = database;
 	xlrec.relfilenode = relfilenode;
 	xlrec.segnum = segnum;
-	xlrec.shared = is_filespace_shared(filespace);
+	xlrec.shared = (SYSTEMFILESPACE_OID!=filespace); //cannot call is_filespace_shared(filespace);
here, it will cause deadlock with PersistentObjLock
     xlrec.persistentTid = *persistentTid;
     xlrec.persistentSerialNum = persistentSerialNum;
 


Mime
View raw message