From dev-return-39929-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Sat Oct 09 12:59:19 2010 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 60283 invoked from network); 9 Oct 2010 12:59:19 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 9 Oct 2010 12:59:19 -0000 Received: (qmail 68305 invoked by uid 500); 9 Oct 2010 12:59:19 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 68144 invoked by uid 500); 9 Oct 2010 12:59:16 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 68135 invoked by uid 99); 9 Oct 2010 12:59:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Oct 2010 12:59:15 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of alexei.fedotov@gmail.com designates 209.85.212.49 as permitted sender) Received: from [209.85.212.49] (HELO mail-vw0-f49.google.com) (209.85.212.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Oct 2010 12:59:08 +0000 Received: by vws11 with SMTP id 11so832781vws.36 for ; Sat, 09 Oct 2010 05:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=D7rGXl7F22QWRknWi8FlmO0mqpI566vz8Ikk2rdAxmk=; b=Ow444nfS2qklJsPJ0at5ssfCRI5TcDkbjM7ItUCpREYvPDlt4DhE71HWrVpDCI3rZZ pm1IGJrbh0VNBTxeQkwOx7qjBwwvONPlyCrEKHoMlkvO4UWMdZBqyequoYKGtsSiA7xT uEfJ1xmMJ1ugfkDxqJk8Uan/Q8aB2maEIj98Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=Df/0tBOm6kzDMlMC/E2e/6opVOaUJ+ES8F7hlna6lPSXcIwCWve8ue2xuxmlrPrKC7 MI4y2FLAujyJ72+DsEeNGcK0LKhsAsuwfrs+cQyDbR52jrTfWG0D+aRIg79chgxqi68L WzmGfS7UDcl4/9GzA+5KVEcqpz8rUSnJeOdq0= Received: by 10.220.192.205 with SMTP id dr13mr1122627vcb.181.1286629126692; Sat, 09 Oct 2010 05:58:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.176.76 with HTTP; Sat, 9 Oct 2010 05:58:06 -0700 (PDT) In-Reply-To: References: From: Alexei Fedotov Date: Sat, 9 Oct 2010 16:58:06 +0400 Message-ID: Subject: Re: Commit to 5 or 6? To: dev@harmony.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Jesse, I'm trying to understand best coding practices. Do you mean replacing assertTrue to assertEquals for assertions like a =3D b? isAvailable() assertions still may be implemented via assertTrue? -- With best regards / =D1=81 =D0=BD=D0=B0=D0=B8=D0=BB=D1=83=D1=87=D1=88=D0=B8= =D0=BC=D0=B8 =D0=BF=D0=BE=D0=B6=D0=B5=D0=BB=D0=B0=D0=BD=D0=B8=D1=8F=D0=BC= =D0=B8, Alexei Fedotov / =D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9 =D0=A4=D0=B5=D0= =B4=D0=BE=D1=82=D0=BE=D0=B2, http://dataved.ru/ +7 916 562 8095 On Tue, Oct 5, 2010 at 3:09 AM, Jesse Wilson wrote= : > Harmony Folks, > > I'm planning to do some work on the Harmony 6 tests. I'm planning to do > small improvements: isolating tests for security managers, replace > assertTrue() with assertEquals(), etc. This work will be driven by me try= ing > to get Android's class library passing Harmony's tests as they appear in > SVN. Currently we only run our own forked copy; that's lame and it double= s > our maintenance burden. > > In which branch should I commit these changes? If I commit to the Java 5 > branch, then the changes benefit both development trees. I'm not personal= ly > interested in Java 5 anymore, but I can't speak for everyone. But if I > commit to the Java 6 branch, I can immediately take advantage of the > changes. I don't want to think about Java 5 and I'm always running the > complete set of Java 6 tests. > > Any guidance? > > Thanks. > > -- > Android libcore team. > =C2=A0office hours every > afternoon, 1=E2=80=935pm >