harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexei Fedotov <alexei.fedo...@gmail.com>
Subject Re: Commit to 5 or 6?
Date Sun, 10 Oct 2010 09:28:41 GMT
Jesse, Mark,
Thanks for explaining your point!

--
With best regards / с наилучшими пожеланиями,
Alexei Fedotov / Алексей Федотов,
http://dataved.ru/
+7 916 562 8095



On Sun, Oct 10, 2010 at 12:36 AM, Mark Hindess
<mark.hindess@googlemail.com> wrote:
>
> In message <AANLkTimRQ6WH546m+KxvUSVgSwRUx4mU5eQhqGp5a2df@mail.gmail.com>,
> Jesse Wilson writes:
> >
> > [snip]
> >
> > It comes up less frequently, but I have some other preferences related
> > to better detail messages. When comparing arrays, equals() does the
> > wrong thing. To work around, I compare the string form for primitives:
> >
> > byte[] actual = ...
> > byte[] expected = ...
> > assertEquals(Arrays.toString(actual), Arrays.toString(expected));
> >
> > And the list form for reference types:
> >
> > Object[] actual = ...
> > Object[] expected = ...
> > assertEquals(Arrays.asList(actual), Arrays.asList(expected));
>
> +1 - expected comes first though.
>
> > I'm not actually planning on doing massive scrubbing to change styles
> > or anything. But when I investigate specific problematic tests, it's
> > helpful to fix the test to tell me everything that it can.
>
> +1.  I tend to fix them if I see any obvious ones on the commit list but
> sometimes I look at the file and decide it's just too much work for the
> time available.
>
> Regards,
>  Mark.
>
>

Mime
View raw message