Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.216.177 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=ct0VZigWYWhhOyOW6aDLyhaJnPA5qwdEqd1w/8WrRGtsIsL+7wZUL4ugd41D4wRI9r
         SPLN6deeKviySCQDmdpNbu/qR6Gfvf7vDN7AC30Q5YZ+XtVYnPSscN9t/G+KmSUz2Oda
         U9hXPBZA/YLYT6DQAHms0MWlA+SXQ83y00rWE=
MIME-Version: 1.0
In-Reply-To: <201009221724.o8MHO9Jd015172@d12av02.megacenter.de.ibm.com>
References: <AANLkTim_ovW+-L+rLm4zRTaS2deGmy-X-Eoc84_Of9qw@mail.gmail.com>
	<4C995D02.4070805@gmail.com>
	<201009221153.o8MBrSZI015934@d12av03.megacenter.de.ibm.com>
	<AANLkTimOk1EtJAeDihpEv=U_rUOfhccs=zWN77xhEYEC@mail.gmail.com>
	<201009221724.o8MHO9Jd015172@d12av02.megacenter.de.ibm.com>
Date: Wed, 22 Sep 2010 21:58:14 +0100
Message-ID: <AANLkTins5CE1FYw4F4ias9dzwXuOwpTUV3iNfExvUTgf@mail.gmail.com>
Subject: Re: running tests / svn:eol-style missing on some files?
From: sebb <sebbaz@gmail.com>
To: dev@harmony.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 22 September 2010 18:24, Mark Hindess <mark.hindess@googlemail.com> wrot=
e:
>
> In message <AANLkTimOk1EtJAeDihpEv=3DU_rUOfhccs=3DzWN77xhEYEC@mail.gmail.=
com>,
> sebb writes:
>>
>> On 22 September 2010 12:53, Mark Hindess <mark.hindess@googlemail.com>
>> wrote:
>> >
>> > In message <4C995D02.4070805@gmail.com>, Tim Ellison writes:
>> >>
>> >> On 21/Sep/2010 22:19, Robert Muir wrote:
>> >> > 2. I think some files are missing svn:eol-style. For example, altho=
ugh
>> >> > i have not modified anything I see:
>> >> >
>> >> > M
>> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/t=
ests/
>> java/net/URLEncoderTest.java
>> >> > M
>> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/t=
ests/
>> java/io/BufferedInputStreamTest.java
>> >> > M
>> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/t=
ests/
>> java/io/InputStreamReaderTest.java
>> >> > M
>> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/t=
ests/
>> java/util/FormatterTest.java
>> >> >
>> >> > Can we set svn:eol-style=3Dnative for these files?
>> >>
>> >> I fixed these specific files @r999716, but it would be good if Mark
>> >> could run his script to check if there are any others that need setti=
ng.
>> >
>> > Fixed at r999793 and r999851.
>>
>> Here are a few more possible ones for
>> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk:
>>
>> svn ps svn:mime-type application/octet-stream
>> classlib/modules/security/src/test/resources/hyts_badpem.cer
>> svn ps svn:eol-style native
>> classlib/support/src/test/java/tests/resources/hyts_checkInput.txt
>> svn ps svn:eol-style native drlvm/vm/gc_gen/src/LICENSE
>> svn ps svn:eol-style native drlvm/vm/gc_gen/src/NOTICE
>> svn ps svn:eol-style native
>> classlib/modules/beans/src/test/resources/xml/ChangedObject.xml
>> svn ps svn:eol-style native
>> classlib/modules/beans/src/test/resources/xml/ClassID.xml
>> svn ps svn:eol-style native
>> classlib/modules/beans/src/test/resources/xml/ObjectID.xml
>> svn ps svn:eol-style native
>> classlib/modules/beans/src/test/resources/xml/StaticField.xml
>>
>> There are also 177 files which have the executable bit set, for example:
>>
>> svn pd svn:executable classlib/depends/files/libhyempty.so
>> svn pd svn:executable
>> classlib/modules/awt/src/main/java/common/java/awt/ActiveEvent.java
>> svn pd svn:executable
>> classlib/modules/awt/src/main/java/common/java/awt/Adjustable.java
>> svn pd svn:executable
>> classlib/modules/awt/src/main/java/common/java/awt/AlphaComposite.java
>>
>> There's rarely a need for this bit to be set; usually if it needs to
>> be set it should be set as part of creating the archives.
>>
>> I can provide the full list if you wish (or you could just delete it
>> from all files).
>
> Thanks Sebb.
>
> I'd intentionally left the test resources as I wanted to make sure
> fixing them didn't break any tests.

If the specific EOL matters, then it is sensible to set it.

These files don't currently have any EOL setting.
All the other XML files in the directory have go eol-style:native

> Oddly LICENSE and NOTICE files are
> missing from the svn auto-props configuration I pulled from the link
> on the NewCommitters page of the Harmony wiki - perhaps they should be
> added?

Can one add files with no extension?

>  - and my script was using that as input.
>
> I've not actually checked any other properties but I'll take a look at
> the svn:mime-type or svn:executable properties shortly. =A0(No need to
> send a full list.)
>
> Any other properties that are worth checking?
>
> Regards,
> =A0Mark.
>
>
>