Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of devyoudw@gmail.com designates
 209.85.213.49 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=GCjRUE4CZSjvA1GWlyhJbMg+epuBMd6M+eMFbREqO16ghijtNVCbQEQ63LfyXxw2Fd
         YAdD52nyedF7pwnGjcsVtGBz2eXkTQ1t64goJ8h6GwtCoDIM2WQBWYsfslDeMjvovyHo
         HC5TyHAsJS0lzsbWJWkdhoToq4PbogaAp39lM=
MIME-Version: 1.0
In-Reply-To: <4C9F963E.2040204@gmail.com>
References: <16508996.357041285200633873.JavaMail.jira@thor>
	<4C9ABC65.6000202@gmail.com>
	<AANLkTi=aoBjQxUAb_mT-bwJgQzTsXsN=7afu4Exiv8we@mail.gmail.com>
	<4C9C0E0B.6080703@gmail.com>
	<AANLkTin+i275fiJ_w9o8qt5Di8q4jKWBOiQVQEZd0rxX@mail.gmail.com>
	<4C9C24C1.6030809@gmail.com>
	<AANLkTi=nU6vfSj+0AfiwrC=1DaYGNkumqW7r0Dheyn82@mail.gmail.com>
	<4C9C31BD.2010504@gmail.com>
	<AANLkTimpEm+ZTC=esH0SR1yoiGO-bZMm=UytLL9R=ug9@mail.gmail.com>
	<4C9C3BFC.2090107@gmail.com>
	<AANLkTimpc7CHLjiPsCH+h0X_=5OUraF8rB2OnCEqQX3k@mail.gmail.com>
	<4C9C44ED.6040506@gmail.com>
	<AANLkTi=hWktGjQcCkZfEd5uHr=tX8HzKn2vGKfExQfJC@mail.gmail.com>
	<AANLkTinw4mkLops3Q883HavGtEbrgWKSExiWPtsu6FL3@mail.gmail.com>
	<4C9CC0C7.5030707@gmail.com>
	<AANLkTi=tAt15jh_kSrA8YZJt0dMVq66Va9adLL9z21UJ@mail.gmail.com>
	<4C9CD1ED.30604@gmail.com>
	<AANLkTi=EQ1zpPh_ZMsv5ae8aO-ferzXxkqu3LK6LT4MH@mail.gmail.com>
	<4C9F963E.2040204@gmail.com>
Date: Mon, 27 Sep 2010 10:26:38 +0800
Message-ID: <AANLkTinKf=oXgRbzaeEcdavXOfOanckxSJSmkaOspuyU@mail.gmail.com>
Subject: Re: [classlib][luni] String.toLowerCase/toUpperCase incorrect for
 supplementary characters (HARMONY-6649)
From: Deven You <devyoudw@gmail.com>
To: dev@harmony.apache.org
Content-Type: multipart/alternative; boundary=00163630f2b94fac480491347558

--00163630f2b94fac480491347558
Content-Type: text/plain; charset=ISO-8859-1

I have tested this patch on my local machine, Ubuntu10.04 x86. It works
well.

2010/9/27 Tim Ellison <t.p.ellison@gmail.com>

> On 24/Sep/2010 17:51, Deven You wrote:
> > Here is the result of Specjbb
>
> I don't have a copy of Specjbb to try, so sorry it broke that.  I think
> I can set up a harmony unit test to emulate the problem here once we
> have an acceptable solution.
>
> Snipped stack trace follows...
> > java.util.Locale (initialization failure)
> > Caused by: java.lang.NullPointerException
> > at com.ibm.icu.util.ULocale.getName(ULocale.java:827)
> > at com.ibm.icu.util.ULocale.<init>(ULocale.java:480)
> > at java.util.Locale.<init>(Locale.java:234)
> > at com.ibm.icu.util.ULocale.<clinit>(ULocale.java:109)
> > at com.ibm.icu.util.TimeZone.getTimeZone(TimeZone.java:617)
> > at java.util.SimpleTimeZone.getICUTimeZone(SimpleTimeZone.java:48)
> > at java.util.SimpleTimeZone.<init>(SimpleTimeZone.java:110)
> > at java.util.TimeZone.<clinit>(TimeZone.java:91)
>
> > I have marked several important stack invocations as red and bold.
>
> Sorry, the red and bold were lost for me, however, I've gone through and
> trimmed down the stack aggressively to show the key parts.
>
> > From above stack trace, Class load process will invoke security
> > methods which will use TimeZone and TimeZone will finally depend on
> > ULocale.
> >
> > I think if our harmony apis need Locale TimeZone info, it always depends
> on
> > icu's ULocale, TimeZone and etc. It can not be avoided during Java
> startup.
>
> Well in this case, yes we do need a TimeZone as part of the certificate
> decoding, but in general we might not need Locale info, so I'm reluctant
> to force a j.u.Locale load too early e.g. by a reference from String.
>
> The 'correct' fix is to change the ICU code to load Locale earlier, I
> guess they don't expect to be early on the boot sequence.  Given we
> can't/don't want to modify ICU for our needs here, I've added (r1001490)
> a reference to Locale during the TimeZone definition to force the load.
>  Please can you check that fixes the problem you see on Specjbb?
>
> There may be other cases that need us to initialize ICU, and I'll look
> for them.  If you have any better ideas of how to get the ordering right
> please say.
>
> Regards,
> Tim
>
>

--00163630f2b94fac480491347558--