Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of devyoudw@gmail.com designates
 209.85.160.177 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=c+HucZLGV9Hgwjn26byTqdoc4tqNr4OgMM4jK8B7m2B0kC0olCc6lltbxWaQUjSVrZ
         3CIju7YwT2wTUVTElIy0gJZYiJ9hPaa9Ycn9MKNBRxhTbsBgPp2suBEJPpO4WCGrq7EJ
         rLNHsL9jggq1Bjat2jVUs7MLPkmmcslnfYLIQ=
MIME-Version: 1.0
In-Reply-To: <AANLkTi=TmX__Y07uQCyhxbdAUMyaJQcMgS9+F+UBNK0G@mail.gmail.com>
References: <16508996.357041285200633873.JavaMail.jira@thor>
	<4C9ABC65.6000202@gmail.com>
	<AANLkTi=aoBjQxUAb_mT-bwJgQzTsXsN=7afu4Exiv8we@mail.gmail.com>
	<4C9C0E0B.6080703@gmail.com>
	<AANLkTin+i275fiJ_w9o8qt5Di8q4jKWBOiQVQEZd0rxX@mail.gmail.com>
	<4C9C24C1.6030809@gmail.com>
	<AANLkTi=nU6vfSj+0AfiwrC=1DaYGNkumqW7r0Dheyn82@mail.gmail.com>
	<4C9C31BD.2010504@gmail.com>
	<AANLkTimpEm+ZTC=esH0SR1yoiGO-bZMm=UytLL9R=ug9@mail.gmail.com>
	<4C9C3BFC.2090107@gmail.com>
	<AANLkTimpc7CHLjiPsCH+h0X_=5OUraF8rB2OnCEqQX3k@mail.gmail.com>
	<4C9C44ED.6040506@gmail.com>
	<AANLkTi=hWktGjQcCkZfEd5uHr=tX8HzKn2vGKfExQfJC@mail.gmail.com>
	<AANLkTinw4mkLops3Q883HavGtEbrgWKSExiWPtsu6FL3@mail.gmail.com>
	<AANLkTi=TmX__Y07uQCyhxbdAUMyaJQcMgS9+F+UBNK0G@mail.gmail.com>
Date: Sat, 25 Sep 2010 01:24:35 +0800
Message-ID: <AANLkTi=c384R558+ktk6VdxxXDTv0r5Aj_vbNjc2nJpN@mail.gmail.com>
Subject: Re: [classlib][luni] String.toLowerCase/toUpperCase incorrect for
 supplementary characters (HARMONY-6649)
From: Deven You <devyoudw@gmail.com>
To: dev@harmony.apache.org
Content-Type: multipart/alternative; boundary=0016e645a406139eeb049104a74c

--0016e645a406139eeb049104a74c
Content-Type: text/plain; charset=ISO-8859-7
Content-Transfer-Encoding: quoted-printable

Hi Mohan,
I have tested the same patch as you, it crashes on drlvm but works well on
j9vm. Please try it. Thanks a lot!

2010/9/24 Mohanraj Loganathan <mohanraj.l@gmail.com>

> Hi Deven,
>
> I followed your steps 1 & 2. But java -version crashes with Harmony5.0
>
> Attaching the out file of java -version.
>
> Thanks and Regards,
> Mohan
>
>
> 2010/9/24 Deven You <devyoudw@gmail.com>:
> > I have saw the error before, and I have some investigation of it. I thi=
nk
> > the root cause is the commit change the class load order. Before this
> > commit, Locale class will be loaded before ULocale class And after this
> > commit, ULocale is loaded before Locale.
> >
> > The direct cause is CharsetProviderImpl no longer use String.toUpperCas=
e,
> > instead it uses its own toUpperCase.  And String.toUpperCase calls
> > String.toUpperCase(Locale), this ensure Locale class will be loaded
> before
> > ULocale. However CharsetProviderImpl own toUpperCase uses no Locale, so
> it
> > causes Locale class loaded after ULocale.
> >
> > To solve this problem, a work around could simply be below:
> > 1.Add a Locale static field in String:
> > private static Locale defaulLocale =3D new Locale.getDefaultLocale();
> > ...
> > 2. Change the String.toUpperCase() from calling
> > toUpperCase(Locale.getDefaultLocale()) to toUpperCase(defaultLocale)
> >
> > above change could solve the NullPointerException mentioned by Mohan, b=
ut
> I
> > am not sure if it is a good design.
> >
> > Caused by: java.lang.NullPointerException
> >       at com.ibm.icu.util.ULocale.getName(ULocale.java:827)
> >       at com.ibm.icu.util.ULocale.<init>(ULocale.java:480)
> >       at java.util.Locale.<init>(Locale.java:228)
> >       at java.util.Locale.<init>(Locale.java:201)
> >       at java.util.Locale.<clinit>(Locale.java:51)
> >       at com.ibm.icu.util.ULocale.<clinit>(ULocale.java:109)
> >
> >
> >
> >
> >
> > 2010/9/24 Mohanraj Loganathan <mohanraj.l@gmail.com>
> >
> >> On loading junit.jar[2] i get initialization exception[3]. This
> >> exception disappears if i revert the patch committed for
> >> (HARMONY-6649) toUpper/toLowerCase.
> >>
> >> Make sure your junit.jar contains the signature files[1]. (use the
> >> junit.jar(version 3.8.2) bundled with eclipse).  So with HARMONY-6649
> >> commit, I am not able to load the jar file if it's manifest contains
> >> any signature related files. Any thought on this?
> >>
> >>
> >> [1] jar -tvf junit.jar
> >>  9714 Thu Aug 07 12:04:14 GMT+05:30 2008 META-INF/MANIFEST.MF
> >>  9791 Thu Aug 07 12:04:14 GMT+05:30 2008 META-INF/ECLIPSE.SF
> >>  3487 Thu Aug 07 12:04:14 GMT+05:30 2008 META-INF/ECLIPSE.RSA
> >>     0 Fri Mar 03 15:22:26 GMT+05:30 2006 META-INF/
> >>    76 Thu Aug 07 12:04:08 GMT+05:30 2008 META-INF/eclipse.inf
> >>     0 Fri Mar 03 15:22:10 GMT+05:30 2006 junit/
> >>     0 Fri Mar 03 15:22:26 GMT+05:30 2006 junit3.8.2/
> >>     0 Fri Mar 03 15:22:24 GMT+05:30 2006 junit/awtui/
> >>      ............
> >>
> >> [2] run command : java -cp junit.jar junit.textui.TestRunner
> >>
> >> [3] Exception:
> >> Uncaught exception in main:
> >> java.lang.ExceptionInInitializerError
> >>        at com.ibm.icu.util.ULocale.<clinit>(ULocale.java:109)
> >>        at
> >> com.ibm.icu.impl.ICUResourceBundle.instantiateBundle(ICUResourceBundl
> >> e.java:810)
> >>        at
> >> com.ibm.icu.impl.ICUResourceBundle.getBundleInstance(ICUResourceBundl
> >> e.java:801)
> >>        at
> >> com.ibm.icu.util.UResourceBundle.getRootType(UResourceBundle.java:489
> >> )
> >>        at
> >> com.ibm.icu.util.UResourceBundle.instantiateBundle(UResourceBundle.ja
> >> va:536)
> >>        at
> >> com.ibm.icu.util.UResourceBundle.getBundleInstance(UResourceBundle.ja
> >> va:144)
> >>        at
> >> com.ibm.icu.util.UResourceBundle.getBundleInstance(UResourceBundle.ja
> >> va:124)
> >>        at com.ibm.icu.impl.ZoneMeta.getSystemTimeZone(ZoneMeta.java:50=
9)
> >>        at com.ibm.icu.util.TimeZone.getTimeZone(TimeZone.java:617)
> >>        at com.ibm.icu.util.TimeZone.getTimeZone(TimeZone.java:587)
> >>        at java.util.SimpleTimeZone$1.run(SimpleTimeZone.java:50)
> >>        at java.util.SimpleTimeZone$1.run(SimpleTimeZone.java:1)
> >>        at
> >> java.security.AccessController.doPrivilegedImpl(AccessController.java
> >> :171)
> >>        at
> >> java.security.AccessController.doPrivileged(AccessController.java:53)
> >>
> >>        at
> java.util.SimpleTimeZone.getICUTimeZone(SimpleTimeZone.java:48)
> >>        at java.util.SimpleTimeZone.<init>(SimpleTimeZone.java:110)
> >>        at java.util.TimeZone.<clinit>(TimeZone.java:91)
> >>        at
> >> org.apache.harmony.security.asn1.ASN1Time.getDecodedObject(ASN1Time.j
> >> ava:51)
> >>        at
> >> org.apache.harmony.security.asn1.ASN1UTCTime.decode(ASN1UTCTime.java:
> >> 96)
> >>        at
> >> org.apache.harmony.security.asn1.ASN1Choice.decode(ASN1Choice.java:32
> >> 0)
> >>        at
> >> org.apache.harmony.security.asn1.BerInputStream.readSequence(BerInput
> >> Stream.java:665)
> >>        at
> >> org.apache.harmony.security.asn1.DerInputStream.readSequence(DerInput
> >> Stream.java:125)
> >>        at
> >> org.apache.harmony.security.asn1.ASN1Sequence.decode(ASN1Sequence.jav
> >> a:48)
> >>        at
> >> org.apache.harmony.security.asn1.BerInputStream.readSequence(BerInput
> >> Stream.java:665)
> >>        at
> >> org.apache.harmony.security.asn1.DerInputStream.readSequence(DerInput
> >> Stream.java:125)
> >>        at
> >> org.apache.harmony.security.asn1.ASN1Sequence.decode(ASN1Sequence.jav
> >> a:48)
> >>        at
> >> org.apache.harmony.security.asn1.BerInputStream.readSequence(BerInput
> >> Stream.java:665)
> >>        at
> >> org.apache.harmony.security.asn1.DerInputStream.readSequence(DerInput
> >> Stream.java:125)
> >>        at
> >> org.apache.harmony.security.asn1.ASN1Sequence.decode(ASN1Sequence.jav
> >> a:48)
> >>        at
> >> org.apache.harmony.security.asn1.BerInputStream.decodeValueCollection
> >> (BerInputStream.java:755)
> >>        at
> >> org.apache.harmony.security.asn1.BerInputStream.readSetOf(BerInputStr
> >> eam.java:733)
> >>        at
> >> org.apache.harmony.security.asn1.DerInputStream.readSetOf(DerInputStr
> >> eam.java:138)
> >>        at
> >> org.apache.harmony.security.asn1.ASN1SetOf.decode(ASN1SetOf.java:48)
> >>        at
> >> org.apache.harmony.security.asn1.ASN1Implicit.decode(ASN1Implicit.jav
> >> a:140)
> >>        at
> >> org.apache.harmony.security.asn1.BerInputStream.readSequence(BerInput
> >> Stream.java:665)
> >>        at
> >> org.apache.harmony.security.asn1.DerInputStream.readSequence(DerInput
> >> Stream.java:125)
> >>        at
> >> org.apache.harmony.security.asn1.ASN1Sequence.decode(ASN1Sequence.jav
> >> a:48)
> >>        at
> >> org.apache.harmony.security.asn1.ASN1Type.decode(ASN1Type.java:97)
> >>        at
> >> org.apache.harmony.security.pkcs7.ContentInfo$1.getDecodedObject(Cont
> >> entInfo.java:153)
> >>        at
> >> org.apache.harmony.security.asn1.ASN1Sequence.decode(ASN1Sequence.jav
> >> a:53)
> >>        at
> >> org.apache.harmony.security.utils.JarUtils.verifySignature(JarUtils.j
> >> ava:73)
> >>        at
> java.util.jar.JarVerifier.verifyCertificate(JarVerifier.java:296)
> >>        at
> java.util.jar.JarVerifier.readCertificates(JarVerifier.java:265)
> >>        at java.util.jar.JarFile.getInputStream(JarFile.java:392)
> >>        at
> >> java.net.URLClassLoader$URLJarHandler.createClass(URLClassLoader.java
> >> :402)
> >>        at
> >> java.net.URLClassLoader$URLJarHandler.findClass(URLClassLoader.java:3
> >> 71)
> >>        at
> java.net.URLClassLoader.findClassImpl(URLClassLoader.java:1209)
> >>        at java.net.URLClassLoader$4.run(URLClassLoader.java:901)
> >>        at java.net.URLClassLoader$4.run(URLClassLoader.java:1)
> >>        at
> >> java.security.AccessController.doPrivilegedImpl(AccessController.java
> >> :171)
> >>        at
> >> java.security.AccessController.doPrivileged(AccessController.java:64)
> >>
> >>        at java.net.URLClassLoader.findClass(URLClassLoader.java:903)
> >>        at java.lang.ClassLoader.loadClass(ClassLoader.java:488)
> >>        at
> >> java.lang.ClassLoader$SystemClassLoader.loadClass(ClassLoader.java:87
> >> 0)
> >>        at java.lang.ClassLoader.loadClass(ClassLoader.java:267)
> >> Caused by: java.lang.NullPointerException
> >>        at com.ibm.icu.util.ULocale.getName(ULocale.java:827)
> >>        at com.ibm.icu.util.ULocale.<init>(ULocale.java:480)
> >>        at java.util.Locale.<init>(Locale.java:228)
> >>        at java.util.Locale.<init>(Locale.java:201)
> >>        at java.util.Locale.<clinit>(Locale.java:51)
> >>        at com.ibm.icu.util.ULocale.<clinit>(ULocale.java:109)
> >>        ... 54 more
> >> FAILED to invoke JVM.
> >>
> >>
> >>
> >>
> >>
> >>
> >> On Fri, Sep 24, 2010 at 11:57 AM, Tim Ellison <t.p.ellison@gmail.com>
> >> wrote:
> >> > On 24/Sep/2010 06:58, Robert Muir wrote:
> >> >> On Fri, Sep 24, 2010 at 1:49 AM, Tim Ellison <t.p.ellison@gmail.com=
>
> >> wrote:
> >> >>
> >> >>> System.out.println(new File("=F3.txt").hashCode());
> >> >>> System.out.println(new File("=F2.txt").hashCode());
> >> >>>
> >> >>> prints out
> >> >>>
> >> >>> 889962580
> >> >>> 890776533
> >> >>>
> >> >>> on both Harmony and the RI.
> >> >>>
> >> >>>
> >> >> but perhaps this is just a bug in the RI?
> >> >> according to the link:
> >> >>
> >>
> http://download.oracle.com/javase/6/docs/api/java/io/File.html#hashCode%2=
8%29
> >> >> <
> >>
> http://download.oracle.com/javase/6/docs/api/java/io/File.html#hashCode%2=
8%29
> >> >Because
> >> >> equality of abstract pathnames is inherently system-dependent, so i=
s
> the
> >> >> computation of their hash codes.
> >> >>
> >> >> Is it a problem that "windows equals" is inconsistent with hashCode
> >> here? I
> >> >> admit these are corner cases.
> >> >
> >> > No, I don't think it is a problem.  I was reviewing the invokers of
> >> > toLowerCase() and was confused by the wording in the spec.  I'm happ=
y
> >> > that we should simply lowercase it in a locale independent way, and
> >> > don't need to do a "windows equals" implementation.
> >> >
> >> > Regards,
> >> > Tim
> >> >
> >>
> >>
> >>
> >> --
> >> Mohan
> >>
> >
>
>
>
> --
> Mohan
>

--0016e645a406139eeb049104a74c--