Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of yanglang@gmail.com designates
 74.125.82.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=PuN42ZHb7qGVHxdbaxGrQGkqORVSLmG/ACkpv2ZJBKsKXCpjkS5egYnsoNdk4sycqw
         PeF5aoM3+ooWil21QFKU2f+D19agUQg8DaZPT7UrxTLKObIfK747sNLrg9t/fuXKqGqE
         d+LV6qkK+XLuI2gOsCtWN5vlgg5oExYWrAztA=
MIME-Version: 1.0
In-Reply-To: <AANLkTi=C=JDftoagHu2AZ5Qz9hN5fLYaEaVri=+7T4iR@mail.gmail.com>
References: <AANLkTimW=53=Ce8VwrqC0F6V44zEp-bmzz7_ZJSmSL1D@mail.gmail.com>
	<AANLkTimYLffikr3fxcg34YPfyErjVPWsa1WEOgxVW5wP@mail.gmail.com>
	<AANLkTi=C=JDftoagHu2AZ5Qz9hN5fLYaEaVri=+7T4iR@mail.gmail.com>
Date: Sun, 8 Aug 2010 20:54:33 -0400
Message-ID: <AANLkTikQFg0zvd68DLwdmAWJyq3R6ip=Amicx637N6Xq@mail.gmail.com>
Subject: Re: [classlib][imageio]PositionStack
From: Lang Yang <yanglang@gmail.com>
To: dev@harmony.apache.org
Content-Type: multipart/alternative; boundary=0016364c7ca7bcf3a4048d59756a

--0016364c7ca7bcf3a4048d59756a
Content-Type: text/plain; charset=UTF-8

Never mind, I think I can just cast int to long, instead of creating a new
int stack.

On Sun, Aug 8, 2010 at 8:46 PM, Lang Yang <yanglang@gmail.com> wrote:

> Hello Alexey,
>
> Thanks for the explanation. It happens that an int stack is also needed. It
> just looks a little bit redundant to have two almost the same classes at
> here though, the only difference is the datetype, one is long, the other one
> is int ;)
>
> Regards,
>
> Lang
>
> On Fri, Aug 6, 2010 at 4:38 AM, Alexey Petrenko <
> alexey.a.petrenko@gmail.com> wrote:
>
>> I see at least two reasons: this class is not synchronized and it
>> works with primitive types instead of objects.
>> So it can be a bit faster on certain circumstances...
>>
>> Thanks.
>>
>> Alexey
>>
>> 2010/8/6 Lang Yang <yanglang@gmail.com>:
>> > Hello guys,
>> >
>> > I was reviewing ImageIO, and found this class:
>> >
>> > javax.imageio.stream.ImageInputStreamImpl:
>> >
>> > private static class PositionStack {
>> > private static final int SIZE = 10;
>> >
>> > private long[] values = new long[SIZE];
>> > private int pos = 0;
>> >
>> > void push(long v) {
>> > if (pos >= values.length) {
>> > ensure(pos + 1);
>> > }
>> > values[pos++] = v;
>> > }
>> >
>> > long pop() {
>> > return values[--pos];
>> > }
>> >
>> > boolean isEmpty() {
>> > return pos == 0;
>> > }
>> >
>> > private void ensure(int size) {
>> > long[] arr = new long[Math.max(2 * values.length, size)];
>> > System.arraycopy(values, 0, arr, 0, values.length);
>> > values = arr;
>> > }
>> > }
>> >
>> > Essentially, it's just a stack, but why do we create this class rather
>> than
>> > just use the standard Stack<Long> class?
>> >
>> > Regards,
>> >
>> > Lang
>> >
>>
>
>

--0016364c7ca7bcf3a4048d59756a--