Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 99922 invoked from network); 2 Aug 2010 15:32:38 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 2 Aug 2010 15:32:38 -0000 Received: (qmail 14288 invoked by uid 500); 2 Aug 2010 15:32:37 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 14173 invoked by uid 500); 2 Aug 2010 15:32:36 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 14159 invoked by uid 99); 2 Aug 2010 15:32:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Aug 2010 15:32:36 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of oliver.deakin@googlemail.com designates 74.125.82.43 as permitted sender) Received: from [74.125.82.43] (HELO mail-ww0-f43.google.com) (74.125.82.43) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Aug 2010 15:32:30 +0000 Received: by wwb18 with SMTP id 18so2638wwb.0 for ; Mon, 02 Aug 2010 08:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=PTfWeZLaEus2MuPLCZ5wmbncLByzT/3jVTdz59PSWDM=; b=iicSfYUx0tRCT6G2EJX6AnXGN3pyO9aqD4WeGndmlrZlFcecN1S5WDs9YXmWzYX28T GUV63Lro8eiSnq2lHKOzeO+EY+96JBgZk187GK0g7+xbZYyc7MAyoS5yV/vopIIiybfE v+iEEvsJwlHzfT6Fuf4ozHJxtCezi/I91QvcI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=lCyHY4H+00Jgdy11+MLfBzoX4ZuL2WsNZEwruIh+HRMommsqEYYqRTbSdB1TC6KoQZ pR2c5QGXDY9NdTBqUqbymf+2IzCyvGJgrhMz8X6oswLnEWtQgIXDac2D0dRP1llXnxz5 a4WCHgxzgCdL9PKLo3x1S36VIPO81/VU8bfZ4= Received: by 10.227.146.149 with SMTP id h21mr5059421wbv.153.1280763129071; Mon, 02 Aug 2010 08:32:09 -0700 (PDT) Received: from [9.20.183.80] (gbibp9ph1--blueice4n1.emea.ibm.com [195.212.29.91]) by mx.google.com with ESMTPS id h3sm5055607wbb.21.2010.08.02.08.32.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 02 Aug 2010 08:32:08 -0700 (PDT) Message-ID: <4C56E4F8.2040105@googlemail.com> Date: Mon, 02 Aug 2010 16:32:08 +0100 From: Oliver Deakin User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1 MIME-Version: 1.0 To: dev@harmony.apache.org Subject: [classlib][luni] Collections classes - code reviews and optimisations Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi all, A little while ago Mark suggested (not sure if it was in person or on the list) that it would be a good idea to take a look at our Collections classes and do a kind of code review, thinking about improvements and possible optimisations. To that end Mark Hindess, Cath Hope and myself sat down and took a close look at ArrayList earlier today. We got up to the growAtEnd() method, annotating the code with questions and comments as we went. I've opened HARMONY-6607 [1] and attached the diff with our comments in so everyone can see what we've come up with so far. If you have any further comments or ideas for the code (including patches for improvements) please add to the discussion here - it would be great to have some extra input! Regards, Oliver [1] https://issues.apache.org/jira/browse/HARMONY-6607 -- Oliver Deakin Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU