Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of yanglang@gmail.com designates
 74.125.82.49 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=hLgoJKLZ74dsv52OpwMH2JsRI9A58tXEmGRyYnwiXscktj9SnRSA+GY9Z0IpKggPfO
         awQXHlltAU0RyCn8Lf0tq46n1cU69s1lkfVmP3ZTw5AcJZeM1kP3/fZJaIwxFEZF9sOV
         cALpjLlIkIxiVsh6RwpHjrAlChC2DsHmC9bxM=
MIME-Version: 1.0
In-Reply-To: <20100523080723.634D9478479@athena.apache.org>
References: <AANLkTikF4lpzDDginyPUd4J7QGVGtAW3q6erZLSB_ys_@mail.gmail.com>
	<AANLkTinpczBF57Qucr9JM-ucWfcFqTGd56jg2aZQ65kw@mail.gmail.com>
	<AANLkTimQYZKiIB5iVho64uaPiw4O-GbxsrdbLxnBxpa0@mail.gmail.com>
	<AANLkTimsldy9QnL0pn9IA3Ljv9j5ZjxgqoTxW9Q7-q_m@mail.gmail.com>
	<20100523080723.634D9478479@athena.apache.org>
Date: Sat, 29 May 2010 02:49:46 -0400
Message-ID: <AANLkTilp5UOxUQp2FfKWHilzealPXmN2XwKAE3nIAK4Y@mail.gmail.com>
Subject: Re: How to test properly when dependent class is not included in RI
From: Lang Yang <yanglang@gmail.com>
To: dev@harmony.apache.org
Content-Type: multipart/alternative; boundary=0016364176bf80af560487b60730

--0016364176bf80af560487b60730
Content-Type: text/plain; charset=UTF-8

Thanks Mark.

I have created a patch under HARMONY-6507 (imageio_build.xml) for this.
Could you please take a look at this?

Because I only need to use plugin classes from
package org.apache.harmony.x.imageio/plugins.* in order to perform the test,
so I have added a section under target "-compile-tests" to create a
supporting JAR file which contains all plugin classes, and added that JAR
file to the classpath of "test-module". It seems fixed the original problem
I had.

I don't know if you prefer to use separate folders, or this way is just
fine?

Thanks,

Lang

On Sun, May 23, 2010 at 4:06 AM, Mark Hindess
<mark.hindess@googlemail.com>wrote:

>
> In message <AANLkTimsldy9QnL0pn9IA3Ljv9j5ZjxgqoTxW9Q7-q_m@mail.gmail.com>,
> Lang Yang writes:
> >
> > Thanks Alexey and Nathan!
> >
> > On Sat, May 22, 2010 at 4:09 PM, Nathan Beyer <ndbeyer@apache.org>
> wrote:
> >
> > > It's not quite as simple as that. There are plenty of cases where
> > > using implementation specific classes is fine - most of the modules
> > > have hundreds of tests like this. This is why many of the modules have
> > > a 'api' and a 'impl' folder separation.
> > >
> >
> > Is that mean If I have used implementation specific classes, I should
> > put the test case in 'impl' folder? Is there an ANT target defined to
> > test them seperate?
>
> Adding a folder for implementation specific tests will require changing
> the modules/imageio/build.xml and modules/imageio/make/run-test.xml and
> changing the src/test directory structure.  I can do this when the code
> freeze is over.
>
> -Mark.
>
>
>

--0016364176bf80af560487b60730--