harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy,Jing Lv" <firep...@gmail.com>
Subject Re: [general] Add a new target for Harmony-Select in the build script
Date Thu, 06 May 2010 02:38:51 GMT
Thanks Mark, Stefan! I'll try new script.

2010/5/4 Mark Hindess <mark.hindess@googlemail.com>

>
> In message <201004211022.o3LAM3XZ015587@d06av02.portsmouth.uk.ibm.com>,
> Mark Hindess writes:
> >
> > In message <
> x2s5c8e69f1004210308p89480fddm285f39499305b261@mail.gmail.com>,
> > "Jimmy,Jing Lv" writes:
> > >
> > > Hello,
> > >
> > >     FYI, I've commit a simple patch into the harmony6 build script,
> > > adding a hy.select property. Anyone who would like to build a
> > > Harmony-select would simply invoke ant -Dhy.select=true.
> > >     Will commit to harmony5 if there is no regression on harmony6.
> >
> > Thanks Jimmy.
> >
> > You really only need:
> >
> > @@ -287,6 +287,10 @@
> >
> >      <!-- default property for poll-modules macro - i.e. all modules -->
> >      <property name="build.module" value="*" />
> > +    <condition property="exclude.module"
> > +
>  value="accessibility,applet,awt,imageio,orb,print,rmi,sound,swing,x_mgt">
> > +        <equals arg1="${hy.select}" arg2="true" />
> > +    </condition>
> >      <property name="exclude.module" value="nothing" />
> >
> >      <!-- flags -->
> >
> > and the rest of your change is redundant as ant properties are (mostly)
> > immutable once defined.  I'd rather not make it more complicated than
> > necessary and I'd like to be consistent with the way other properties
> > (such as jpeg.home just above this change) are defined.
> >
> > Also, I'm not sure the list of excluded modules is correct for java6.
> > java6 doesn't have an x_mgt module but perhaps you meant jmx?  And I
> > think we should consider excluding some others, such as jaxb, jaxws,
> > jws, script, saaj, stax, xmlsec?
>
> In r940765, I've rewritten the property using simplified ant code and
> removed the reference to the invalid module 'x_mgt'.  I'm still interested
> to know what you think about the other modules we should be excluding?
>
>
yes, it seems x-management module has renamed to jmx (though Harmony use a
external dependence). Exclude this will be fine. I shall check the script.

In r940766, I've committed the new definition to trunk.
>
> Regards,
>  Mark.
>
>
>


-- 

Best Regards!

Jimmy, Jing Lv
China Software Development Lab, IBM

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message