harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Zhou <zhoukevi...@gmail.com>
Subject Re: svn commit: r935847 - in /harmony/enhanced/java/trunk/classlib/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/file/ test/api/common/org/apache/harmony/luni/tests/internal/net/www/protocol/file/
Date Tue, 20 Apr 2010 11:31:08 GMT
Thanks, Mark and Sebb

On Tue, Apr 20, 2010 at 6:37 PM, sebb <sebbaz@gmail.com> wrote:

> Also, consider whether the header field could be made final - it looks
> like it is only set in the constructor.
>
> On 20/04/2010, Kevin Zhou <zhoukevin83@gmail.com> wrote:
> > OK, thanks!
> >
> >  We'll stick to the process now. I have asked Mohan to raise a JIRA and
> >  attach the patch with granting license to ASF, will commit it later.
> >
> >  On Tue, Apr 20, 2010 at 6:11 PM, Mark Hindess
> >  <mark.hindess@googlemail.com>wrote:
> >
> >
> >  >
> >  > In message <201004201004.o3KA42Ao021185@d12av04.megacenter.de.ibm.com
> >,
> >  > Mark Hindess writes:
> >  > >
> >  > > In message <4BCD79F9.2010806@gmail.com>, Kevin Zhou writes:
> >  > > >
> >  > > > On 2010-4-20 17:38, zhoukevin@apache.org wrote:
> >  > > > > Author: zhoukevin
> >  > > > > Date: Tue Apr 20 09:38:04 2010
> >  > > > > New Revision: 935847
> >  > > > >
> >  > > > > URL: http://svn.apache.org/viewvc?rev=935847&view=rev
> >  > > > > Log:
> >  > > > > This patch implements the header related functions
> >  > > > > [getHeaderField(int)/get
> >  > > > HeaderFieldKey(int)/getHeaderField(String)/getLastModified()] to
> >  > prevent
> >  > > > Harmony to return null when file URL is handled.
> >  > > > >
> >  > > > > [SNIP]
> >  > > >
> >  > > > This patch is provided by Mohanraj Loganathan, Thanks.
> >  > >
> >  > > Then Mohanraj *must* submit it to JIRA and grant license to the ASF
> to
> >  > > use it.  You *should* not commit it until he does this.
> >  > >
> >  > > Please back it out and follow the correct process.  The process is
> >  > > exists for good reason.
> >  >
> >  > I've back this out in r935857.
> >  > -Mark.
> >  >
> >  >
> >  >
> >
> >
> >
> > --
> >  Best regards,
> >  Yours, Kevin Zhou
> >
>



-- 
Best regards,
Yours, Kevin Zhou

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message