harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject Re: [general] Add a new target for Harmony-Select in the build script
Date Wed, 21 Apr 2010 10:22:02 GMT

In message <x2s5c8e69f1004210308p89480fddm285f39499305b261@mail.gmail.com>,
"Jimmy,Jing Lv" writes:
>
> Hello,
> 
>     FYI, I've commit a simple patch into the harmony6 build script,
> adding a hy.select property. Anyone who would like to build a
> Harmony-select would simply invoke ant -Dhy.select=true.
>     Will commit to harmony5 if there is no regression on harmony6.

Thanks Jimmy.

You really only need:

@@ -287,6 +287,10 @@
     
     <!-- default property for poll-modules macro - i.e. all modules -->
     <property name="build.module" value="*" />
+    <condition property="exclude.module"
+        value="accessibility,applet,awt,imageio,orb,print,rmi,sound,swing,x_mgt">
+        <equals arg1="${hy.select}" arg2="true" />
+    </condition>
     <property name="exclude.module" value="nothing" />
 
     <!-- flags -->

and the rest of your change is redundant as ant properties are (mostly)
immutable once defined.  I'd rather not make it more complicated than
necessary and I'd like to be consistent with the way other properties
(such as jpeg.home just above this change) are defined.

Also, I'm not sure the list of excluded modules is correct for java6.
java6 doesn't have an x_mgt module but perhaps you meant jmx?  And I
think we should consider excluding some others, such as jaxb, jaxws,
jws, script, saaj, stax, xmlsec?

Regards,
 Mark.




Mime
View raw message