From dev-return-39098-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Tue Mar 23 21:21:44 2010 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 88124 invoked from network); 23 Mar 2010 21:21:44 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Mar 2010 21:21:44 -0000 Received: (qmail 1420 invoked by uid 500); 23 Mar 2010 21:21:44 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 1385 invoked by uid 500); 23 Mar 2010 21:21:44 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 1376 invoked by uid 99); 23 Mar 2010 21:21:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Mar 2010 21:21:44 +0000 X-ASF-Spam-Status: No, hits=-1.6 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_MED,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 194.196.100.161 is neither permitted nor denied by domain of mark.hindess@googlemail.com) Received: from [194.196.100.161] (HELO mtagate1.uk.ibm.com) (194.196.100.161) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Mar 2010 21:21:33 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o2NLLBJv019485 for ; Tue, 23 Mar 2010 21:21:11 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o2NLLBpn1458420 for ; Tue, 23 Mar 2010 21:21:11 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o2NLLBCI023343 for ; Tue, 23 Mar 2010 21:21:11 GMT Received: from anaheim.local (sig-9-145-192-116.de.ibm.com [9.145.192.116]) by d06av02.portsmouth.uk.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id o2NLLBgu023332 for ; Tue, 23 Mar 2010 21:21:11 GMT Message-Id: <201003232121.o2NLLBgu023332@d06av02.portsmouth.uk.ibm.com> X-Mailer: exmh version 2.7.2 01/07/2005 (debian 1:2.7.2-18) with nmh-1.3 From: "Mark Hindess" To: "Apache Harmony Dev List" Subject: [classlib][auth] JndiLoginModule Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 23 Mar 2010 21:21:11 +0000 X-Virus-Checked: Checked by ClamAV on apache.org modules/auth/src/main/java/common/org/.../auth/module/JndiLoginModule.java contains fields: public final String USER_PROVIDER = "group.provider.url"; public final String GROUP_PROVIDER = "user.provider.url"; I wonder why: 1) they are not static? 2) USER_PROVIDER contains 'group' and GROUP_PROVIDER contains 'user'? 3) they aren't used to replace the occurrences of these strings in the code (of course, the previous item might make this confusing)? Anyone know if there are any reasons not to fix any of the above? I'd attempt some obvious fixes to the above but I don't understand the context in which this class is used and was too confused to do this without sanity checking. Regards, Mark.