harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Regis <xu.re...@gmail.com>
Subject Re: [classlib][fdlib] Upgrade fdlibm5.2 to 5.3
Date Wed, 10 Mar 2010 09:33:23 GMT
On 2010-03-07 19:03, Mark Hindess wrote:
>
> In message<4B933B24.9060607@gmail.com>, Regis writes:
>>
>> On 2010-03-03 17:31, Mark Hindess wrote:
>>> +1
>>>
>>> Thanks Deven.
>>>
>>> We should move to a process that downloads the upstream zip using the
>>> standard {check,fetch}-depends mechanism to make it easier to update in
>>> future.  Ideally the dependency should be pushed down to the luni module
>>> where it really belongs.
>>>
>>> Regards,
>>> -Mark.
>>>
>>> In message<4B90C728.5020509@gmail.com>, Regis writes:
>>>>
>>>> On 2010-03-03 16:34, Deven You wrote:
>>>>> See https://issues.apache.org/jira/browse/HARMONY-6460, since
>>>>> java spec require fdlibm5.3, I think we should upgrade it from at
>>>>> present 5.2 to 5.3.
>>>>> What about your opinions? Thanks a lot!
>>>>
>>>> Great founding! It seems fdlibm5.3 is released earlier than Harmony
>>>> project starting (fdlibm5.3 revised October 2002, when Harmony
>>>> project is not started yet), I don't know why we didn't pick the
>>>> latest version, but used the older one. Is there any concern
>>>> here? If not, I think we should upgrade it after M13 released.
>>
>> I attached a new patch on HARMONY-6460 to maintains fdlibm dependency
>> by "standard {check,fetch}-depends mechanism", please help to review
>> if that the right way to do this. Thanks.
>
> As I said before, ideally, since this dependency is required only by
> luni, then this dependency should be dealt with in modules/luni/build.xml
> not in the top-level build/depends files.  See the awt dependencies for
> a similar example of this.
>
> Regards,
>   Mark.
>
>
>

Thanks Mark, new patch followed your suggestion applied at r921268.


-- 
Best Regards,
Regis.

Mime
View raw message