From dev-return-38939-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Wed Feb 17 17:03:49 2010 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 91023 invoked from network); 17 Feb 2010 17:03:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Feb 2010 17:03:49 -0000 Received: (qmail 67535 invoked by uid 500); 17 Feb 2010 17:03:48 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 67455 invoked by uid 500); 17 Feb 2010 17:03:48 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 67444 invoked by uid 99); 17 Feb 2010 17:03:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Feb 2010 17:03:48 +0000 X-ASF-Spam-Status: No, hits=-2.8 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 195.212.17.165 is neither permitted nor denied by domain of mark.hindess@googlemail.com) Received: from [195.212.17.165] (HELO mtagate5.de.ibm.com) (195.212.17.165) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Feb 2010 17:03:37 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.1/8.13.1) with ESMTP id o1HH3Hu4001573 for ; Wed, 17 Feb 2010 17:03:17 GMT Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com [9.149.165.229]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o1HH3GUL1532042 for ; Wed, 17 Feb 2010 18:03:17 +0100 Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o1HH3GHC017557 for ; Wed, 17 Feb 2010 18:03:16 +0100 Received: from anaheim.local (gbv83124.uk.ibm.com [9.145.115.159]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id o1HH3GNp017551 for ; Wed, 17 Feb 2010 18:03:16 +0100 Message-Id: <201002171703.o1HH3GNp017551@d12av04.megacenter.de.ibm.com> X-Mailer: exmh version 2.7.2 01/07/2005 (debian 1:2.7.2-18) with nmh-1.3 In-reply-to: References: Comments: In-reply-to Jesse Wilson message dated "Wed, 17 Feb 2010 08:35:10 -0800." From: Mark Hindess To: Harmony Dev Subject: Re: svn commit: r910980 - /harmony/enhanced/classlib/branches/java6/modules/luni/src/main/java/java/util/TreeMap.java Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 17 Feb 2010 17:03:14 +0000 X-Virus-Checked: Checked by ClamAV on apache.org In message , Jesse Wilson writes: > > I noticed something weird in commit 910980: > > Author: hindessm > Date: Wed Feb 17 14:07:42 2010 > New Revision: 910980 > > URL: http://svn.apache.org/viewvc?rev=910980&view=rev > Log: > Thought I'd reverted this already ... reverting r903454. See: > > http://markmail.org/thread/cdxlmi26mjgor3om > > Modified: > harmony/enhanced/classlib/branches/java6/modules/luni/src/main/java/java/ > util/TreeMap.java > > I think you're moving in the wrong direction. The toComparable method > needs a null check. You can see this by reading the TreeMap code from > the Java 5 > branch uni/src/main/java/java/util/TreeMap.java>. > Harmony doesn't have explicit test coverage here, but you can verify > the bug by running other publicly-available JDK test suites against > Harmony. > > Mark, can you revert this commit? I have solid evidence that this change is wrong... it breaks Harmony tests that pass on the RI. I've no solid evidence that this change is required. So my inclination is not to put the check back. A null check may be required but I'm not convinced this is the right place for it. The toComparable method is just a trivial helper function that is clearly being used (probably quite reasonably) in a context that doesn't require a null check. Sorry, I've not got time to investigate this further right now but rest assured we will get to the bottom of it and fix it correctly. Raise a JIRA if you want to make sure it doesn't get forgotten. Regards, Mark.