From dev-return-38915-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Wed Feb 10 11:31:38 2010 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 27411 invoked from network); 10 Feb 2010 11:31:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 10 Feb 2010 11:31:38 -0000 Received: (qmail 7218 invoked by uid 500); 10 Feb 2010 11:31:37 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 7144 invoked by uid 500); 10 Feb 2010 11:31:37 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 7133 invoked by uid 99); 10 Feb 2010 11:31:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Feb 2010 11:31:37 +0000 X-ASF-Spam-Status: No, hits=-2.8 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 195.212.17.163 is neither permitted nor denied by domain of mark.hindess@googlemail.com) Received: from [195.212.17.163] (HELO mtagate3.de.ibm.com) (195.212.17.163) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Feb 2010 11:31:28 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.1/8.13.1) with ESMTP id o1ABV6Ye019260 for ; Wed, 10 Feb 2010 11:31:06 GMT Received: from d12av03.megacenter.de.ibm.com (d12av03.megacenter.de.ibm.com [9.149.165.213]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o1ABV5WA1277978 for ; Wed, 10 Feb 2010 12:31:06 +0100 Received: from d12av03.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av03.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o1ABV4cV010188 for ; Wed, 10 Feb 2010 12:31:04 +0100 Received: from anaheim.local (dhcp-9-20-183-172.hursley.ibm.com [9.20.183.172]) by d12av03.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id o1ABV42Q010183 for ; Wed, 10 Feb 2010 12:31:04 +0100 Message-Id: <201002101131.o1ABV42Q010183@d12av03.megacenter.de.ibm.com> X-Mailer: exmh version 2.7.2 01/07/2005 (debian 1:2.7.2-18) with nmh-1.3 In-reply-to: <70c070d81002091921w43f62f6qc3d77f48db650c6a@mail.gmail.com> References: <70c070d81002091921w43f62f6qc3d77f48db650c6a@mail.gmail.com> Comments: In-reply-to James Gan message dated "Wed, 10 Feb 2010 11:21:04 +0800." From: Mark Hindess To: dev@harmony.apache.org Subject: Re: About the newest version of lockfree ReferenceQueue Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 10 Feb 2010 11:31:04 +0000 In message <70c070d81002091921w43f62f6qc3d77f48db650c6a@mail.gmail.com>, James Gan writes: > > Dear all, > > My personal experience of using this new ReferenceQueue is great. Now > one end of the queue is lock-free. But another end is protected by > lock. I'll like to know your comments about the new design. Thanks! > > Here is the patch: > https://issues.apache.org/jira/secure/attachment/12424562/rfq.patch James, I tried to take a look at this patch (with a view to running some benchmarks) but: 1) The patch seems to be changing the package names from java.lang.ref to java.lang. I've no idea why but it would certainly make the result unusable. 2) The patch seems to be against a version of these classes prior to "r824035 | hindessm | 2009-10-11 08:03:04" when I removed the CVS Revision keywords. It would be useful to have a patch against the current version. I tried jumping through some hoops to get it to apply: mkdir -p /tmp/HARMONY-6344/java/lang cp working_vm/vm/vmcore/src/kernel_classes/javasrc/java/lang/ref/Ref*.java \ /tmp/HARMONY-6344/java/lang cd /tmp/HARMONY-6344 patch -p1 rfq.patch # attach new patch to JIRA. svn st | grep '^\?' # check for any new files # attach new files if necessary Let me know if you need more assistance. Regards, Mark.