harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse Wilson <jessewil...@google.com>
Subject Re: svn commit: r910980 - /harmony/enhanced/classlib/branches/java6/modules/luni/src/main/java/java/util/TreeMap.java
Date Wed, 17 Feb 2010 16:35:10 GMT
I noticed something weird in commit 910980:


Author: hindessm
Date: Wed Feb 17 14:07:42 2010
New Revision: 910980

URL: http://svn.apache.org/viewvc?rev=910980&view=rev
Log:
Thought I'd reverted this already ... reverting r903454.  See:

  http://markmail.org/thread/cdxlmi26mjgor3om

Modified:
    harmony/enhanced/classlib/branches/java6/modules/luni/src/main/java/java/util/TreeMap.java

I think you're moving in the wrong direction. The toComparable method needs
a null check. You can see this by reading the TreeMap code from the Java 5
branch<http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/TreeMap.java>.
Harmony doesn't have explicit test coverage here, but you can verify the bug
by running other publicly-available JDK test suites against Harmony.

Mark, can you revert this commit?

Thanks,
Jesse

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message