harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From regis xu <xu.re...@gmail.com>
Subject Re: svn commit: r889137 - in /harmony/enhanced/classlib/trunk/modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument: HelloWorldTest.java InstrumentTestHelper.java agents/HelloWorldAgent.java
Date Thu, 21 Jan 2010 09:05:53 GMT
On Thu, Jan 21, 2010 at 4:51 PM, Mark Hindess
<mark.hindess@googlemail.com>wrote:

>
> In message <64f79c3e1001202313x1fd8aacdmf5e45dfca84b72a4@mail.gmail.com>,
> regis xu writes:
> >
> > On Thu, Jan 21, 2010 at 3:57 AM, Mark Hindess
> > <mark.hindess@googlemail.com> wrote:
> > >
> > > Regis,
> > >
> > > It looks like my "harmless" commit below broke some tests on
> > > Linux[1].  I think this means there is a problem with the code
> > > though since I don't think line endings should be significant.  Any
> > > chance you could take a look?
> > >
> > > Regards,
> > >  Mark.
> > >
> > > [1]
> > >
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/37/testReport/
> >
> > I can't open this link, it report a 404 error. Can you paste
> > stack trace here? It passed on my Linux desktop. May be a
> > environment/configuration problems.
>
> Sorry, I linked to the oldest build with the problem, but there has
> probably been a new build and the oldest one was delete.
>
> I'm not convinced it is just a local configuration problem.  It works
> for me with an IBM VM but fails with DRLVM.
>
> Regards,
>  Mark.
>
>
>
It passed for me with both IBM vm and drlvm. Can you reproduce it on your
machine? Patch[1] may
help to find out what happened on the forked process.

[1]

Index:
modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument/HelloWorldTest.java
=====================================================================
---
modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument/HelloWorldTest.java
+++
modules/instrument/src/test/java/org/apache/harmony/tests/java/lang/instrument/HelloWorldTest.java
@@ -53,6 +53,11 @@ public class HelloWorldTest extends TestCase {

         helper.run();

+        System.out.println("std err:");
+        System.out.println(helper.getStdErr());
+        System.out.println("std out:");
+        System.out.println(helper.getStdOut());
+
         assertEquals(0, helper.getExitCode());
         assertEquals("Hello World" + LINE_SEPARATOR, helper.getStdOut());
         assertEquals("", helper.getStdErr());
@@ -72,6 +77,11 @@ public class HelloWorldTest extends TestCase {

         helper.run();

+        System.out.println("std err:");
+        System.out.println(helper.getStdErr());
+        System.out.println("std out:");
+        System.out.println(helper.getStdOut());
+
         assertEquals(0, helper.getExitCode());
         assertEquals("Hello World" + LINE_SEPARATOR, helper.getStdOut());
         assertEquals("", helper.getStdErr());
@@ -91,6 +101,11 @@ public class HelloWorldTest extends TestCase {

         helper.run();

+        System.out.println("std err:");
+        System.out.println(helper.getStdErr());
+        System.out.println("std out:");
+        System.out.println(helper.getStdOut());
+
         assertTrue(0 != helper.getExitCode());
         assertTrue(helper.getStdErr().contains(
                 ClassNotFoundException.class.getName()));

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message