harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject Re: [classlib][concurrent] CopyOnWriteArrayList
Date Wed, 20 Jan 2010 18:14:58 GMT

In message <4B573CFB.7040301@gmail.com>, Tim Ellison writes:
> As you probably know, our concurrency code is a copy of the code in Doug
> Lea's JSR166 repository.  You may also recall that the JSR166 version of
> CopyOnWriteArrayList [1] contains an unpalatable Sun copyright notice,
> so we created a Harmony version of this class as a replacement [2].
> Unfortunately, when we refreshed the implementation from Doug's
> repository back in July 2009 [3,4] the Harmony version was overwritten
> with the JSR166 version containing the original copyright statement.
> The remedy is to restore the Harmony version [5].  Of course we need to
> also check that it implements the right behavior of the refreshed code etc.
> Since we are currently distributing the original JSR166 version in our
> latest 5.0 M12 download, I propose that we now also produce a 5.0M12a
> containing the replacement file.
> Although this file has been in our builds since last July, we should not
> wait until the next scheduled Harmony milestone.  So, the 5.0M12a build
> will be a minimal change, derived by creating a tag based on 5.0M12
> (r885602) and fixing this one file.  That means we can have a shorter
> release cycle with reduced testing etc. and replace M12 with M12a.

I think this is the right thing to do.  Since "creating a tag" is not as
trivial as it sounds (due to the structure of our federated build), I'll
make a start on doing this while awaiting further comments/consensus.


> Comments and questions welcome.
> [1]
> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/concurre
> nt/src/main/java/java/util/concurrent/CopyOnWriteArrayList.java?view=log
> [2] http://issues.apache.org/jira/browse/HARMONY-1805
> [3] http://issues.apache.org/jira/browse/HARMONY-6262
> [4] http://svn.apache.org/viewvc?view=revision&revision=794678
> [5] http://svn.apache.org/viewvc?rev=901123&view=rev
> Regards,
> Tim

View raw message