Return-Path: 
 <dev-return-38686-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org>
Delivered-To: apmail-harmony-dev-archive@www.apache.org
Received: (qmail 79870 invoked from network); 19 Dec 2009 10:05:04 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 19 Dec 2009 10:05:04 -0000
Received: (qmail 22479 invoked by uid 500); 19 Dec 2009 10:05:03 -0000
Delivered-To: apmail-harmony-dev-archive@harmony.apache.org
Received: (qmail 22386 invoked by uid 500); 19 Dec 2009 10:05:02 -0000
Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@harmony.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@harmony.apache.org>
List-Post: <mailto:dev@harmony.apache.org>
List-Id: <dev.harmony.apache.org>
Reply-To: dev@harmony.apache.org
Delivered-To: mailing list dev@harmony.apache.org
Received: (qmail 22375 invoked by uid 99); 19 Dec 2009 10:05:02 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Dec 2009 10:05:02 +0000
X-ASF-Spam-Status: No, hits=-2.6 required=5.0
	tests=BAYES_00
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of gcjhd-harmony-dev@m.gmane.org
 designates 80.91.229.12 as permitted sender)
Received: from [80.91.229.12] (HELO lo.gmane.org) (80.91.229.12)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Dec 2009 10:04:53 +0000
Received: from list by lo.gmane.org with local (Exim 4.50)
	id 1NLwAn-00027V-Qp
	for dev@harmony.apache.org; Sat, 19 Dec 2009 11:04:29 +0100
Received: from packo.static.corbina.ru ([78.107.249.77])
        by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <dev@harmony.apache.org>; Sat, 19 Dec 2009 11:04:29 +0100
Received: from egor.pasko by packo.static.corbina.ru with local (Gmexim 0.1
 (Debian))
        id 1AlnuQ-0007hv-00
        for <dev@harmony.apache.org>; Sat, 19 Dec 2009 11:04:29 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: dev@harmony.apache.org
From: Egor Pasko <egor.pasko@gmail.com>
Subject: Re: [jira] Created: (HARMONY-6404) possible data-reordering in some
 hashCode-methods (e.g. String or URL)
Date: Sat, 19 Dec 2009 13:04:05 +0300
Lines: 26
Message-ID: <87pr6bwa96.fsf@gmail.com>
References: <981540465.1260477018418.JavaMail.jira@brutus>
 <4B21BE3A.4030202@gmail.com>
 <6554f93c0912102009n45e4981btfc072f0c6feacca7@mail.gmail.com>
 <4B221ABA.4040809@gmail.com> <87638doa25.fsf@gmail.com>
 <4B226D80.4040309@gmail.com>
 <3b3f27c60912112000h7c52613ajbbc9692150a3a44e@mail.gmail.com>
 <871vj0o42m.fsf@gmail.com> <4B29FA62.2050801@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Complaints-To: usenet@ger.gmane.org
X-Gmane-NNTP-Posting-Host: packo.static.corbina.ru
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
Cancel-Lock: sha1:bcCimU/FFZ/U1dWd30KfCs0Eqgk=
Sender: news <news@ger.gmane.org>

On the 0x68A day of Apache Harmony Tim Ellison wrote:
> On 12/Dec/2009 10:54, Egor Pasko wrote:
>> On the 0x685 day of Apache Harmony Nathan Beyer wrote:
> <snip>
>>> In any case, it does seem a pinch more efficient to only do one read
>>> of hashCode ... switch up the code to be something like this.
>>>
>>> public int hashCode() {
>>>     final int hash = hashCode;
>>>     if (hash == 0) {
>>>         if (count == 0) {
>>>             return 0;
>>>         }
>>>         for (int i = offset; i < count + offset; i++) {
>>>             hash = value[i] + ((hash << 5) - hash);
>>>         }
>>>         hashCode = hash;
>> 
>> one more 'return hash' here, please :)
>
> Why?

argh, what was I thinking about? the original Nathan's code is great.

-- 
Egor Pasko