From dev-return-38700-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Mon Dec 21 11:32:51 2009 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 71736 invoked from network); 21 Dec 2009 11:32:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 21 Dec 2009 11:32:51 -0000 Received: (qmail 88824 invoked by uid 500); 21 Dec 2009 11:32:50 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 88737 invoked by uid 500); 21 Dec 2009 11:32:50 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 88725 invoked by uid 99); 21 Dec 2009 11:32:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Dec 2009 11:32:48 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of alexei.fedotov@gmail.com designates 209.85.220.220 as permitted sender) Received: from [209.85.220.220] (HELO mail-fx0-f220.google.com) (209.85.220.220) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Dec 2009 11:32:38 +0000 Received: by fxm20 with SMTP id 20so5361196fxm.15 for ; Mon, 21 Dec 2009 03:32:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=QyupIEp51OKWD+bNHQyTgC6/+Eu/bzRq/exR/Dh7oIU=; b=ByK7phDfArvZ+PWkEhM8Nc39NsBqUGP6RnnO9v7d7BMOR/g+hdPwwru6qAL1ntW6Mc Scikva0aQcfqxTsbglj6W0yfshszRx9SIOr1w1oDTpLbyA/meRrzpBD8yIbooTskW/rc 25+xol9UC2d0UVRe+e/Vj1GC/SVb6X7PAVO2o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=Z0biekDTUQrwNSprHssNboMCptLuSU6bbE3a3FhQk1H48GCpu0tmmbfk2dw9jQqte0 EGuIDjECizTP6LqGDqsNJRvuAhC3kvGtAaf7Ui5pei43AP0vuThgdXN7WuMewHj38/IK hE4OaXNMuWhKoCp/fot2BO/hm4PKrfm+lI/80= MIME-Version: 1.0 Received: by 10.239.145.163 with SMTP id s35mr739392hba.42.1261395134929; Mon, 21 Dec 2009 03:32:14 -0800 (PST) In-Reply-To: <87ljgzw9wi.fsf@gmail.com> References: <5b06ca0e0912150403q4f9ab2a9p7fcc8a846b333476@mail.gmail.com> <87ljgzw9wi.fsf@gmail.com> Date: Mon, 21 Dec 2009 14:32:14 +0300 Message-ID: Subject: Re: patch OK? From: Alexei Fedotov To: dev@harmony.apache.org Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable Egor, I share your concern. Ever changing nature of today's world implies that optimizing JIT have to be aware of JVMTI, though I cannot request implementing that from the patch author. On Sat, Dec 19, 2009 at 1:11 PM, Egor Pasko wrote: > On the 0x689 day of Apache Harmony Alexei Fedotov wrote: >> [added dev@] >> >> Egor, >> Thanks for asking for review. I miss code exercises. The code looks >> ok. BTW, the review took me here [1] - thanks Google for the wonderful >> instrument. >> >> As for your last question, TI appeared in java earlier than >> java.lang.instrument. This means implementing the latter using the >> former may make some sense. >> >> [1] http://www.google.com/codesearch/p?hl=3Dru#TasP9sO-cIM/trunk/vm/vmco= re/src/jvmti/jvmti.cpp&q=3Dload_agentlib&exact_package=3Dhttp://svn.apache.= org/repos/asf/harmony/enhanced/drlvm/ > > Thanks, Alexey! > > I am totally not an expert in TI, please, correct me. > > My concern was that in TI mode DRLVM runs slower. One reason to this > is that Jitrino.OPT does not support TI. It sounds like a high price > to pay for some innocent instrumentations. What can we do about this? > > -- > Egor Pasko > > --=20 With best regards / =D3 =CE=C1=C9=CC=D5=DE=DB=C9=CD=C9 =D0=CF=D6=C5=CC=C1= =CE=C9=D1=CD=C9, Alexei Fedotov / =E1=CC=C5=CB=D3=C5=CA =E6=C5=C4=CF=D4=CF=D7, http://www.telecom-express.ru/ http://harmony.apache.org/ http://www.expressaas.com/ http://openmeetings.googlecode.com/