Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of t.p.ellison@gmail.com
 designates 209.85.218.210 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:x-enigmail-version:content-type
         :content-transfer-encoding;
        b=AAZqfp88rCne0Cgf4GIyN3vnVv6bji/35LlbL712yKmiBtggj18FkyhnVvXjLiQnAx
         8HDsX5rnrrj/6cHna6+39vmWqWXCpFIts1Xk+oNRndf62qKQh+JqW/gL8gyfvciuPcNK
         EaeZB31QeTK0GniWff7JcMN2R6Ws9Z06OEIDU=
Message-ID: <4B0D33E3.5090105@gmail.com>
Date: Wed, 25 Nov 2009 13:40:51 +0000
From: Tim Ellison <t.p.ellison@gmail.com>
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: dev@harmony.apache.org
Subject: [testing] tools failure (was: Re: [testing] M12 testing on Windows
 x86)
References: <4B0BEE4F.1080601@gmail.com>
In-Reply-To: <4B0BEE4F.1080601@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On 24/Nov/2009 14:31, Tim Ellison wrote:
> Name                                               Tests Errors Failures
> org.apache.harmony.tests.tools.javac                   2      1      0

This is a failure caused by missing JAR files on the test classpath.

We used to have explicit code to find and load JAR files from the
tools.jar using reflection, and I changed that to put the JAR files on
the manifest's Class-Path:.  I messed it up.

The classpath is set right for the command-line tool, but not for the
JUnit test.

I would like to fix it using this patch,

Index: working_jdktools/modules/jdktools/META-INF/MANIFEST.MF
===================================================================
--- working_jdktools/modules/jdktools/META-INF/MANIFEST.MF	(revision 884022)
+++ working_jdktools/modules/jdktools/META-INF/MANIFEST.MF	(working copy)
@@ -5,7 +5,10 @@
 Implementation-Vendor: The Apache Software Foundation
 Implementation-Vendor-Id: org.apache.harmony
 Implementation-URL: http://harmony.apache.org
-Class-Path: ecj-3.4.2.jar,jdi.jar,jdimodel.jar,bcel-5.2.jar
+Class-Path: com.ibm.icu.base_3.6.1.v20070417.jar
+  ecj-3.4.2.jar
+  jdimodel.jar
+  jdtstub.jar
 Bundle-ManifestVersion: 2
 Bundle-Name: Harmony Tools
 Bundle-SymbolicName: org.apache.harmony.tools


Please could somebody review and approve this change.

Regards,
Tim