Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of t.p.ellison@gmail.com
 designates 72.14.220.159 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:x-enigmail-version:content-type
         :content-transfer-encoding;
        b=adzgBdyDobS4SD+QlFS+iKSWFflmxJRBaWeC8WhzsHoKNA5FSdS/m2WRydIDtqIIiH
         yx7vlqS+hq1loLsvOs7todXp7MHohqWjj9tVrxD1kfegX43xgFcdQhA5/ZSsgolPssqc
         FAkc8qToXokcRw0sSxxdKozrb4uuyq4OUK4gc=
Message-ID: <4AF9397A.2010104@gmail.com>
Date: Tue, 10 Nov 2009 09:59:22 +0000
From: Tim Ellison <t.p.ellison@gmail.com>
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: dev@harmony.apache.org
Subject: Re: svn commit: r834317 - in /harmony/enhanced/classlib/trunk:
 modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/io/
 support/src/test/java/org/apache/harmony/testframework/
References: <20091110031206.9479F2388901@eris.apache.org>
In-Reply-To: <20091110031206.9479F2388901@eris.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

> These tests fail! There should be 7 new failures.

Then put the tests into the exclude list until you get the fixes in
place.  Leaving it broken is not helpful.

I've updated the LUNI exclude list at r834407.

Regards,
Tim

On 10/Nov/2009 03:12, jessewilson@apache.org wrote:
> Author: jessewilson
> Date: Tue Nov 10 03:12:06 2009
> New Revision: 834317
> 
> URL: http://svn.apache.org/viewvc?rev=834317&view=rev
> Log:
> A bunch of new tests for OutputStreams.
> 
> This uses composition to create many tests (86 tests in this case) with few lines of code. This is most useful for things like OutputStream and Collection where there are multiple implementations that satisfy the same core behaviour. I intend to eventually create a similar set of testers for InputStreams, Readers and Writers. The main advantage of this style of test is that it becomes easy to check that all implementations conform to a specified behaviour.
> 
> The motivation for this specific set is a bug in FilteredStream.flush(), where we are ignoring an exception thrown by an underlying stream. These tests fail! There should be 7 new failures. I intend to commit a change that has the fix tomorrow.
> 
> Added:
>     harmony/enhanced/classlib/trunk/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/io/OutputStreamTesterTest.java
>     harmony/enhanced/classlib/trunk/support/src/test/java/org/apache/harmony/testframework/SinkTester.java
>     harmony/enhanced/classlib/trunk/support/src/test/java/org/apache/harmony/testframework/WrapperTester.java