From dev-return-38542-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Wed Nov 25 21:51:28 2009 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 48775 invoked from network); 25 Nov 2009 21:51:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 25 Nov 2009 21:51:28 -0000 Received: (qmail 36323 invoked by uid 500); 25 Nov 2009 21:51:28 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 36258 invoked by uid 500); 25 Nov 2009 21:51:27 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 36247 invoked by uid 99); 25 Nov 2009 21:51:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Nov 2009 21:51:27 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00 X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of t.p.ellison@gmail.com designates 74.125.78.147 as permitted sender) Received: from [74.125.78.147] (HELO ey-out-1920.google.com) (74.125.78.147) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Nov 2009 21:51:24 +0000 Received: by ey-out-1920.google.com with SMTP id 3so1495193eyh.4 for ; Wed, 25 Nov 2009 13:51:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=mDymcIhWpYLYKfcqxCiq2ekghg3QYez38SfCGMHug74=; b=JSGWr1XxGppfsFtvJ3356KD7Cioa/sJo240AiM+GtjQ6EGT3rWe7Dc7B02rhPtdpee XgT4aCE8FxDeX+iXGlaJ31eiNH+jbc+UsDMxvzruI2Ony7z4F7EtR10Adkdk+liUjk9x DIJa68QnjUv7+rCB5a0BsjAKg0VGmP0EJWFXs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=j+DiQ5lnFG5/7CPkNrOwl2nMGf8aJft9oWi8iZOIDMejzBcMNuf3L1y+qFwserttHf sFpx6ThTBYupUiX0nNQiFo6xTlriERutCdVdUI5lUYZoYPuOuzUe38L+i26Tfjwwl10V wk+Un9xENJr50wxiMTN98NfthTGYBRVPVvIo8= Received: by 10.213.23.199 with SMTP id s7mr8381976ebb.80.1259185863294; Wed, 25 Nov 2009 13:51:03 -0800 (PST) Received: from ?192.168.0.5? ([92.26.166.5]) by mx.google.com with ESMTPS id 13sm39768ewy.9.2009.11.25.13.51.01 (version=SSLv3 cipher=RC4-MD5); Wed, 25 Nov 2009 13:51:02 -0800 (PST) Message-ID: <4B0DA6C3.4020409@gmail.com> Date: Wed, 25 Nov 2009 21:50:59 +0000 From: Tim Ellison User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: dev@harmony.apache.org Subject: Re: [testing] tools failure References: <4B0BEE4F.1080601@gmail.com> <4B0D33E3.5090105@gmail.com> <200911251940.nAPJef4a008718@d12av03.megacenter.de.ibm.com> In-Reply-To: <200911251940.nAPJef4a008718@d12av03.megacenter.de.ibm.com> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 25/Nov/2009 19:40, Mark Hindess wrote: > In message <4B0D33E3.5090105@gmail.com>, Tim Ellison writes: >> On 24/Nov/2009 14:31, Tim Ellison wrote: >>> Name Tests Errors Failures >>> org.apache.harmony.tests.tools.javac 2 1 0 >> This is a failure caused by missing JAR files on the test classpath. >> >> We used to have explicit code to find and load JAR files from the >> tools.jar using reflection, and I changed that to put the JAR files on >> the manifest's Class-Path:. I messed it up. >> >> The classpath is set right for the command-line tool, but not for the >> JUnit test. >> >> I would like to fix it using this patch, >> >> Index: working_jdktools/modules/jdktools/META-INF/MANIFEST.MF >> =================================================================== >> --- working_jdktools/modules/jdktools/META-INF/MANIFEST.MF (revision 88402 >> 2) >> +++ working_jdktools/modules/jdktools/META-INF/MANIFEST.MF (working copy) >> @@ -5,7 +5,10 @@ >> Implementation-Vendor: The Apache Software Foundation >> Implementation-Vendor-Id: org.apache.harmony >> Implementation-URL: http://harmony.apache.org >> -Class-Path: ecj-3.4.2.jar,jdi.jar,jdimodel.jar,bcel-5.2.jar >> +Class-Path: com.ibm.icu.base_3.6.1.v20070417.jar >> + ecj-3.4.2.jar >> + jdimodel.jar >> + jdtstub.jar >> Bundle-ManifestVersion: 2 >> Bundle-Name: Harmony Tools >> Bundle-SymbolicName: org.apache.harmony.tools > > > This fixes the problem for me. So I am +1 for applying it. Thanks, fixed in r884286. I'm still testing but I don't think there are any failures left that will block the milestone. I'll post more results tomorrow. Regards, Tim