From dev-return-38510-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Mon Nov 23 22:29:40 2009 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 73018 invoked from network); 23 Nov 2009 22:29:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Nov 2009 22:29:40 -0000 Received: (qmail 25043 invoked by uid 500); 23 Nov 2009 22:29:39 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 24947 invoked by uid 500); 23 Nov 2009 22:29:39 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 24936 invoked by uid 99); 23 Nov 2009 22:29:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2009 22:29:39 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of t.p.ellison@gmail.com designates 209.85.219.220 as permitted sender) Received: from [209.85.219.220] (HELO mail-ew0-f220.google.com) (209.85.219.220) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2009 22:29:30 +0000 Received: by ewy20 with SMTP id 20so2239990ewy.20 for ; Mon, 23 Nov 2009 14:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=4MEvnSNytH8U9+/aGnRCLe5ikp9PEu1RtmlLPmIx4yA=; b=v4v63awygvRuqMBkfTTDDSMEb5LgQ3HcacsnKQeu5qnuvHX8S4c+Pv7MQZFAV4Z/c5 dv6HY6uGoI7vloX+6u9x0XA3gLFKHSFhWCoHoaHpOPFO4lcKefFfCP/nytK+MeWmnDIE c2IOSwTCOm8nYDyGOlCFp5pQWSEQhqZ6EwchU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=b+GQ87wjn4CtDVlQULHBxKRzlMB2ybFAQGMGeXCyxoXbvOZa1YX0Za0f6cDWDLveqh bZnrs4Ci4BS9eW82RTk6MqQBhp5XFsvkr2G8SpFdzxs41yzt7MgZvsSsvOxncOnP7gdL g8BPSpNBFWYe6ibIDgAMKm6NgFy3Qr+B6VvnE= Received: by 10.213.110.201 with SMTP id o9mr5465540ebp.35.1259015350296; Mon, 23 Nov 2009 14:29:10 -0800 (PST) Received: from ?192.168.0.5? ([78.146.53.70]) by mx.google.com with ESMTPS id 15sm88612ewy.4.2009.11.23.14.29.08 (version=SSLv3 cipher=RC4-MD5); Mon, 23 Nov 2009 14:29:09 -0800 (PST) Message-ID: <4B0B0CB1.9040206@gmail.com> Date: Mon, 23 Nov 2009 22:29:05 +0000 From: Tim Ellison User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: dev@harmony.apache.org Subject: Re: svn commit: r883478 - in /harmony/enhanced/classlib/trunk: modules/archive/make/exclude.common modules/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarFileTest.java support/src/test/java/tests/resources/hyts_flushed.jar References: <20091123200323.508DB2388987@eris.apache.org> <4B0AEE42.6010504@gmail.com> In-Reply-To: X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 23/Nov/2009 20:27, Jesse Wilson wrote: > My bad for committing during the code freeze. So you're going to rollback, esp. so we don't exclude all the other tests in that type? > Does it make sense to limit test changes during the code freeze? I don't see > any benefit. We ensure that the tests pass and we ship the tests as part of our Milestone deliveries. The benefit of including them in the code freeze is that we are not trying to hit a moving target and/or introducing new bugs (i.e. the same reasons the implementation code stays frozen during final test/release). Regards, Tim