harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse Wilson <jessewil...@google.com>
Subject Re: svn commit: r835212 - /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/io/BufferedReader.java
Date Fri, 13 Nov 2009 19:10:35 GMT
On Fri, Nov 13, 2009 at 9:41 AM, Tim Ellison <t.p.ellison@gmail.com> wrote:

> I took a look at the tests briefly, they are checking exception throwing
> compatibility, something that we aim to maintain with the RI as rightly
> or wrongly apps depend upon non-spec'd behavior.

Sorry about this guys.

One of the engineering problems I'm working through is that Android has its
own copy of the Harmony test suite. It has additional tests, plus some
changes to the original test suite. I'm not particularly happy having two
copies! Anyway, in submitting this change I'd run the BufferedReader changes
through our test suite, but not Harmony's, and as a consequence I've broken
some tests. I'll take better care going forward. The silver lining in this
is that Android has many tests to contribute in time.

I've committed the fix as r835954.

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message