harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: Problems bulding with VS 2008
Date Mon, 09 Nov 2009 09:31:57 GMT
On 09/Nov/2009 04:20, Charles Lee wrote:
> That's strange. I also encounter the same problem when I build federate.

Ok, I'll go through and remove the /comment options from the link lines.
  In the meantime I've just removed the comment pass through in our
rules at repo revision r834004.

FWIW I'm using "Microsoft (R) Incremental Linker Version 9.00.21022.08"
and don't see the same problems.

> Besides, there is also a tiny comment problem:
> 
> diff --git modules/awt/src/main/native/fontlib/shared/Tables.h
> modules/awt/src/main/native/fontlib/shared/Tables.h
> index 61c8bed..02cf43d 100644
> --- modules/awt/src/main/native/fontlib/shared/Tables.h
> +++ modules/awt/src/main/native/fontlib/shared/Tables.h
> @@ -167,7 +167,7 @@ typedef struct
>         fshort ascender;                     /* typographic ascent */
>         fshort descender;             /* typographic descent */
>         fshort line_gap;              /* typographic line gap */
> -       ufshort advance_width_max;    /* Maximum advance width value in
> \221hmtx\222 table */
> +       ufshort advance_width_max;    /* Maximum advance width value in
> \u0060hmtx\u00B4 table */
>         fshort min_left_sidebearing;
>         fshort min_right_sidebearing; /* Min(aw - lsb - (xMax - xMin)) */
>         fshort xMaxExtent;            /* Max(lsb + (xMax - xMin)) */
> 
> The original one using a octal form, which will fail on my platform code
> page (CP_936). I have changed it to the unicode one and it pass.

I just replaced them with ' in repo revision r834003.

> Also I have noticed that in our build script, we do not specify the javac
> encoding. Is there any concern on this?

I looked at the ECJ options page, but it doesn't say what default
encoding will be used.  We could explicitly state it as "UTF-8" if you
are having trouble?

Regards,
Tim

> On Thu, Nov 5, 2009 at 6:40 PM, Tim Ellison <t.p.ellison@gmail.com> wrote:
> 
>> On 05/Nov/2009 06:30, Charles Lee wrote:
>>> I am trying to build harmony java6 using vs 2008 and a LINK ERROR
>> occurred:
>>> *LINK : warning LNK4044: unrecognized option '/comment:Platform port
>> ......*
>>> *
>>> *
>>> *It seems visual studio 2008 does not support /comment link option any
>>> more. *
>>> *1. Is it ok to delete the comment option?*
>>> *2. Is there a way to add these comment some where?*
>> Strange, I can compile the Java 5 branch ok with VS2008 using the same
>> command lines.
>>
>> Anyway, I suggest that we remove the /comment linker option and ensure
>> that the VS_VERSION_INFO block is up to date in the DLL's .rc file.
>>
>> Regards,
>> Tim
>>
>>
> 
> 

Mime
View raw message