harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: Problems bulding with VS 2008
Date Thu, 05 Nov 2009 15:38:37 GMT
On 05/Nov/2009 10:40, Tim Ellison wrote:
> On 05/Nov/2009 06:30, Charles Lee wrote:
>> I am trying to build harmony java6 using vs 2008 and a LINK ERROR occurred:
>>
>> *LINK : warning LNK4044: unrecognized option '/comment:Platform port ......*
>> *
>> *
>> *It seems visual studio 2008 does not support /comment link option any
>> more. *
>> *1. Is it ok to delete the comment option?*
>> *2. Is there a way to add these comment some where?*
> 
> Strange, I can compile the Java 5 branch ok with VS2008 using the same
> command lines.
> 
> Anyway, I suggest that we remove the /comment linker option and ensure
> that the VS_VERSION_INFO block is up to date in the DLL's .rc file.

p.s. Of course, the quick fix for you to make progress is to remove the
COMMENT var from the makefile rules, i.e.

Index: depends/build/rules.mak
===================================================================
--- depends/build/rules.mak	(revision 832793)
+++ depends/build/rules.mak	(working copy)
@@ -49,7 +49,6 @@
 	link $(VMLINK) /debug /opt:icf /opt:ref /INCREMENTAL:NO /NOLOGO \
 	/NODEFAULTLIB:libcmt /NODEFAULTLIB:libc /FORCE:UNRESOLVED \
 	-entry:_DllMainCRTStartup$(DLLENTRY) -dll /BASE:$(DLLBASE)
-machine:$(CPU) \
-	$(COMMENT) \
 	-subsystem:windows -out:$@ \
 	-map:$(LIBPATH)$(*F).map -pdb:$(DBGPATH)$(*F).pdb \
         -manifestfile:$(LIBPATH)$(*F).manifest \

and we can tidy up the makefiles lazily.

Tim

Mime
View raw message