Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (nike.apache.org: domain of gshimansky@gmail.com designates
 209.85.220.222 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:from:to:subject:date:user-agent:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding
         :content-disposition:message-id;
        b=WTcfVCJIH59cpvrDgX1+whG+oIud5rJx2PWQOyNCuvYk/q2MsedJo8I6SfavQONDkq
         ua9mylN+wMbPrAxMUPa7PzF052o/ymkXVwXHNw8wJTImmR5VsuFoCA+wTHYspxBaMSlG
         c8Pa8TIM8kkO316hKyp6A992dm46mP5HuNjTQ=
Sender: Gregory Shimansky <gshimansky@gmail.com>
From: Gregory Shimansky <gshimansky@apache.org>
To: dev@harmony.apache.org
Subject: Re: Idiomatic Java: return-at-method-end in Harmony
Date: Tue, 27 Oct 2009 00:58:58 +0300
User-Agent: KMail/1.9.10
References: <a43fbc6a0910261434w274ded20s14e3b3ed99331299@mail.gmail.com>
In-Reply-To: <a43fbc6a0910261434w274ded20s14e3b3ed99331299@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200910270058.59096.gshimansky@apache.org>

On 27 October 2009 Jesse Wilson wrote:
> Harmony Team,
>
> Some of the Java code in Harmony suffers from being written in a non-Java
> style. In particular, our Java code often attempts to limit the number of
> exit points from a method. This approach is common in C/C++ programs
> because of the need to manually collect garbage.

I don't think anyone who writes C/C++ cares about it. Usually such style is a 
result of changes upon changes on some code with intention to make minimal 
changes to it.

> In patches I'll be submitting, I'll use the second form, which is idiomatic
> Java. I may also submit patches that convert the first style to the second,
> but usually only when there's other useful cleanup to accompany it. If
> you'd rather I not, please let me know and we'll arm-wrestle.

If it works, don't fix it.

-- 
Gregory