harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oliver Deakin <oliver.dea...@googlemail.com>
Subject Re: svn commit: r829056 - /harmony/enhanced/classlib/trunk/modules/luni/src/main/native/luni/shared/OSNetworkSystem.c
Date Tue, 27 Oct 2009 09:45:25 GMT
Jesse Wilson wrote:
> On Mon, Oct 26, 2009 at 8:26 AM, Oliver Deakin <oliver.deakin@googlemail.com
>   
>> wrote:
>>     
>
>   
>> Wouldn't it be more appropriate to just relax the constraints on
>>     
>>> hysock_connect_with_timeout?
>>>
>>>       
>> Sure, what would you suggest? I believe the reason the portlib function was
>> implemented this way (only a short 100ms timeout maximum) is because on some
>> platforms it is not possible to interrupt blocking calls, so once you go
>> into the block there is no way to stop it for, for example, VM shutdown.
>>
>>     
>
> We should just put the loop in the platform-specific port! Behavior on good
> platforms shouldn't suffer just so we can support crappy platforms!
>   

Not sure I would call them crappy platforms, but I agree it should be 
fixed in the platform specific code. I'll take a look and refactor this 
down into the port library when I have time to check behaviour across 
the various supported platforms.

Regards,
Oliver



-- 
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU


Mime
View raw message