harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Regis <xu.re...@gmail.com>
Subject Re: [jira] Commented: (HARMONY-6312) Concurrency problems in NIO
Date Tue, 13 Oct 2009 07:23:32 GMT
Jesse Wilson wrote:
> So Regis and I disagree on the merit of maintaining indices. Actually
> disagreeing on such things is generally healthy since mobile/Android prefers
> simplicity and memory efficiency, whereas serverside prefers high
> throughput. Yet I still feel that the index optimizations were misguided,
> particularly since more effective, simpler optimizations were left on the
> table (and now live in my patch).
> 
> Regardless, I'd prefer to focus on getting the noncontroversial changes
> checked in. Alongside some controversial stuff, the patch I attached on
> Monday includes fixes for a keyset liveness bug. It also saves some
> unnecessary object allocation.
> 
> Please apply some or all of the patch. Or let me know how I can improve it,
> so that you'd be inclined to do so.
> 
> Thanks!
> 

I have committed the patch of NIO_Concurrency_issues_2.patch except part of 
"Remove indices and iterate the selected set each select()". I split the patch 
manually, hope I didn't mess anything up :)

-- 
Best Regards,
Regis.

Mime
View raw message