harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gregory Shimansky <gshiman...@apache.org>
Subject Re: Idiomatic Java: return-at-method-end in Harmony
Date Mon, 26 Oct 2009 21:58:58 GMT
On 27 October 2009 Jesse Wilson wrote:
> Harmony Team,
> Some of the Java code in Harmony suffers from being written in a non-Java
> style. In particular, our Java code often attempts to limit the number of
> exit points from a method. This approach is common in C/C++ programs
> because of the need to manually collect garbage.

I don't think anyone who writes C/C++ cares about it. Usually such style is a 
result of changes upon changes on some code with intention to make minimal 
changes to it.

> In patches I'll be submitting, I'll use the second form, which is idiomatic
> Java. I may also submit patches that convert the first style to the second,
> but usually only when there's other useful cleanup to accompany it. If
> you'd rather I not, please let me know and we'll arm-wrestle.

If it works, don't fix it.


View raw message