harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject Re: svn commit: r829056 - /harmony/enhanced/classlib/trunk/modules/luni/src/main/native/luni/shared/OSNetworkSystem.c
Date Mon, 26 Oct 2009 21:13:44 GMT

In message <a43fbc6a0910261014q12cd8c79j29c8bfb4311dfa31@mail.gmail.com>,
Jesse Wilson writes:
>
> On Mon, Oct 26, 2009 at 8:26 AM, Oliver Deakin <oliver.deakin@googlemail.com>
> wrote:
> >
> > Jesse Wilson wrote:
> > >
> > > Wouldn't it be more appropriate to just relax the constraints on
> > > hysock_connect_with_timeout?
> >
> > Sure, what would you suggest? I believe the reason the portlib
> > function was implemented this way (only a short 100ms timeout
> > maximum) is because on some platforms it is not possible to
> > interrupt blocking calls, so once you go into the block there is no
> > way to stop it for, for example, VM shutdown.
>
> We should just put the loop in the platform-specific port! Behavior
> on good platforms shouldn't suffer just so we can support crappy
> platforms!

+1

That is exactly what I was thinking when I read Oliver's comment.  If there
is no platform-independent reason for this behaviour then it should be fixed
in platform-specific code.

-Mark



Mime
View raw message