Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: neutral (nike.apache.org: 195.212.29.141 is neither permitted
 nor denied by domain of mark.hindess@googlemail.com)
Message-Id: <200909160803.n8G83G8s028713@d06av04.portsmouth.uk.ibm.com>
In-reply-to: <4AAF8ECD.70005@googlemail.com> 
References: <200909142011.n8EKBid8013737@d06av01.portsmouth.uk.ibm.com>
 <4AAF8ECD.70005@googlemail.com>
Comments: In-reply-to Oliver Deakin <oliver.deakin@googlemail.com>
   message dated "Tue, 15 Sep 2009 13:55:41 +0100."
From: Mark Hindess <mark.hindess@googlemail.com>
To: dev@harmony.apache.org
Subject: Re: [portlib][hythr] Minor API change: use const char* from names 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 16 Sep 2009 09:03:16 +0100


In message <4AAF8ECD.70005@googlemail.com>, Oliver Deakin writes:
>
> Mark Hindess wrote:
> >
> > I plan to modify the hythread api so that it uses "const char*"
> > for names of threads and monitors rather than the current "char*".
> > Since the former is more appropriate and avoids errors (when using
> > const strings) without appropriate casts on recent versions of
> > gcc.  (For instance, you can't build the federated build with
> > -Dhy.no.thr=true with recent versions of gcc because of a warning
> > treated as an error in jdktools/modules/jpda.)
> >   
> 
> +1 - I fixed a few of these a while back where I got compiler warnings. 
> const char * is the appropriate type for these, as you say.

I've made this change in r815644 for trunk.  Since the java6 branch
shares the drlvm trunk, I also made commit r815646 in the classlib java6
branch to keep things in sync.

-Mark.