harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject Re: [portlib][hythr] Minor API change: use const char* from names
Date Wed, 16 Sep 2009 08:03:16 GMT

In message <4AAF8ECD.70005@googlemail.com>, Oliver Deakin writes:
> Mark Hindess wrote:
> >
> > I plan to modify the hythread api so that it uses "const char*"
> > for names of threads and monitors rather than the current "char*".
> > Since the former is more appropriate and avoids errors (when using
> > const strings) without appropriate casts on recent versions of
> > gcc.  (For instance, you can't build the federated build with
> > -Dhy.no.thr=true with recent versions of gcc because of a warning
> > treated as an error in jdktools/modules/jpda.)
> >   
> +1 - I fixed a few of these a while back where I got compiler warnings. 
> const char * is the appropriate type for these, as you say.

I've made this change in r815644 for trunk.  Since the java6 branch
shares the drlvm trunk, I also made commit r815646 in the classlib java6
branch to keep things in sync.


View raw message