Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (nike.apache.org: domain of oliver.deakin@googlemail.com
 designates 209.85.218.207 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=Q76wQqd8NFRxj3l7eeuOZuHkbOs52npJjfPHwYQtIquds1/baHOF9whNRc8niWw+WH
         pc8uaZHy1yhhwnUCXcWzQcVZHEiiDfr4tJkqTP8Hzb9KDqt5Ou0yvCAw4Tzm8qCETBs6
         WZB7tycHuZ7q2BxGeZllUeTQhRy7UuOmkYUHM=
Message-ID: <4A7AA7AF.1050609@googlemail.com>
Date: Thu, 06 Aug 2009 10:51:43 +0100
From: Oliver Deakin <oliver.deakin@googlemail.com>
User-Agent: Thunderbird 2.0.0.22 (Windows/20090605)
MIME-Version: 1.0
To: dev@harmony.apache.org
Subject: Re: svn commit: r801484 - HARMONY-6279 file.encoding improvement
References: <20090806010230.9DD53238887A@eris.apache.org>
 <200908060854.n768ssZ3025945@d06av02.portsmouth.uk.ibm.com>
In-Reply-To: <200908060854.n768ssZ3025945@d06av02.portsmouth.uk.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Mark Hindess wrote:
> <SNIP!>
> I notice that there are '$Revision...' tags in over 3k files in classlib
> alone but since we don't have svn keyword expansion enabled (and I hope
> we never do) then most are either not expanded or they were expanded
> elsewhere and are just misleading in the context of our svn repository.
> I suggest we remove them?
>   

+1 to removing the revision tags - I don't think they are any use at the 
moment, not just because they don't get expanded but also because they 
don't cover all files.

Regards,
Oliver

> (I'd rather not see author tags either but I'm not sure everyone agrees
> with this.  There is some discussion in the list archives.)
>
>   
>> [snip]
>>     
>
>   
>> Modified: modules/luni/src/main/native/luni/windows/helpers.c
>> --- modules/luni/src/main/native/luni/windows/helpers.c (original)
>> +++ modules/luni/src/main/native/luni/windows/helpers.c Thu Aug  6 01:02:29 2009
>> @@ -25,12 +25,14 @@
>>  #include <windows.h>
>>  #include <winbase.h>
>>  #include <stdlib.h>
>> +#include <stdio.h>
>>  #include <LMCONS.H>
>>  #include <direct.h>
>>     
>
> I don't have a windows machine configured to build Harmony right now but I
> suspect that stdio.h was only required for your debugging and can/should
> be removed from any patches/commits?
>
> Regards,
>  Mark.
>
>
>
>   

-- 
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU